fix: add dual CJS/ESM package exports for Vite 8 interop#134
Merged
Conversation
Brezinben
reviewed
Apr 21, 2026
| "jest-circus": "^29.5.0", | ||
| "jest-junit": "^15.0.0", | ||
| "lint-staged": ">=13", | ||
| "tsup": "^8.5.0", |
There was a problem hiding this comment.
on tsup page :
[!WARNING] This project is not actively maintained anymore. Please consider using tsdown instead. Read more in the migration guide.
It's ok for you to use it ?
Member
Author
There was a problem hiding this comment.
tsdown requires Node 20+, so we'll need to bump the Node version as well. Technically, it's a breaking change
Member
Author
|
@Brezinben thank you! What do you think about the idea of moving ESM-only? |
For major version can be good, maybe after minimal node version >= 20 |
Member
Author
|
Yes, it would be a v3 release with ESM-only support, and increased minimal version of Node to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch build to tsup and publish both CJS and ESM entrypoints via exports/import/require fields. This preserves existing CommonJS usage while fixing default-import behavior in Vite 8/Rolldown environments.