Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] ironic: Install deploy image with ironic #2406

Open
wants to merge 1 commit into
base: stable/5.0-pike
Choose a base branch
from

Conversation

skazi0
Copy link
Member

@skazi0 skazi0 commented May 6, 2020

The official SUSE deploy image package will be installed by default
together with ironic-server role. Kernel and ramdisk images will be
uploaded to glance.

(cherry picked from commit a9507ce)

port of #2100

NOTE This is needed to enable functional ironic testing in SOC8 CI

The official SUSE deploy image package will be installed by default
together with ironic-server role. Kernel and ramdisk images will be
uploaded to glance.

(cherry picked from commit a9507ce)
code "#{openstack_cmd} #{openstack_args_glance} image create \
--disk-format ari --container-format ari --public \
--file #{image_path}/initrd #{ramdisk_image_prefix}-#{image_version_cmd}"
not_if "#{openstack_cmd} #{openstack_args_glance} image list -f value -c Name | grep -q #{ramdisk_image_prefix}-#{image_version_cmd}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [135/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

code "#{openstack_cmd} #{openstack_args_glance} image create \
--disk-format aki --container-format aki --public \
--file #{image_path}/vmlinux #{kernel_image_prefix}-#{image_version_cmd}"
not_if "#{openstack_cmd} #{openstack_args_glance} image list -f value -c Name | grep -q #{kernel_image_prefix}-#{image_version_cmd}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [134/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

# openstack-ironic-image.x86_64-9.0.0.kernel.4.12.14-95.13-default
# find all x.y.z version substrings and pick the first one to be used
# as version suffix
image_version_cmd = "$(readlink #{image_path}/vmlinux | egrep -o '[0-9]+\\.[0-9]+\\.[0-9]+' | head -n1)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [104/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

@skazi0 skazi0 requested a review from jsuchome May 6, 2020 11:33
@JanZerebecki
Copy link
Contributor

mkcloud ironic CI failed, that'll need to be fixed first.

@skazi0
Copy link
Member Author

skazi0 commented Jan 13, 2021

@JanZerebecki this is a chicken/egg problem. This PR is part of work which was supposed to lead to a working ironic CI. IIRC there were some other problems which were causing CI failures in SOC8 ironic but I'm not sure if it's worth the effort to get back to fixing this.

@JanZerebecki JanZerebecki removed the wip label Jan 13, 2021
@JanZerebecki
Copy link
Contributor

So that means this doesn't break anything? Then we can merge it.

@skazi0
Copy link
Member Author

skazi0 commented Jan 13, 2021

It should not break anything.

@stefannica stefannica removed their request for review March 11, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants