Add azuread_privileged_access_group_assignment_schedule, azuread_privileged_access_group_eligibility_schedule #192
Conversation
chatelain-io
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
…rivileged_access_group_eligibility_schedule Signed-off-by: Alexandre Chatelain <[email protected]> Signed-off-by: Alexandre Chatelain <[email protected]>
Signed-off-by: Alexandre Chatelain <[email protected]> Signed-off-by: Alexandre Chatelain <[email protected]>
Signed-off-by: Alexandre Chatelain <[email protected]> Signed-off-by: Alexandre Chatelain <[email protected]>
chatelain-io
force-pushed
the
feature/azuread_privileged_access_group_eligibility_schedule
branch
from
5c9620d to
113bde3
Compare
Signed-off-by: Alexandre Chatelain <[email protected]>
Signed-off-by: Alexandre Chatelain <[email protected]>
There was a problem hiding this comment.
Hey @chatelain-io,
Welcome, and thank you for your first contribution! 🎉 I appreciate your effort in adding these new resources.
I took a quick look at your PR and noticed that the newly added resources haven't been copied to the examples folder. This step is mentioned in step 7 of the Adding a New Resource guide. Could you please update the PR to include them?
Signed-off-by: Alexandre Chatelain <[email protected]>
|
@turkenf |
|
/test-examples="examples/privileged/v1beta1/accessgroupassignmentschedule.yaml" |
Signed-off-by: Alexandre Chatelain <[email protected]>
chatelain-io
force-pushed
the
feature/azuread_privileged_access_group_eligibility_schedule
branch
from
ba8b632 to
76da3de
Compare
Signed-off-by: Alexandre Chatelain <[email protected]>
|
/test-examples="examples/privileged/v1beta1/accessgroupassignmentschedule.yaml" |
1 similar comment
|
/test-examples="examples/privileged/v1beta1/accessgroupassignmentschedule.yaml" |
|
/test-examples="examples/privileged/v1beta1/accessgroupeligibilityschedule.yaml" |
Description of your changes
Add
azuread_privileged_access_group_assignment_schedule
azuread_privileged_access_group_eligibility_schedule
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Still need to produce a green pipeline via uptests