-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emr_cluster, emr_instance_fleet, emr_instance_group #1416
base: main
Are you sure you want to change the base?
Add emr_cluster, emr_instance_fleet, emr_instance_group #1416
Conversation
/test-examples="examples/emr/v1beta1/cluster.yaml,examples/emr/v1beta1/instancefleet.yaml,examples/emr/v1beta1/instancegroup.yaml" |
Many thanks, @sanhaKimVics 🙌 I will take a look at in detail next week. |
/test-examples="examples/emr/v1beta1/instancefleet.yaml" |
/test-examples="examples/emr/v1beta1/instancegroup.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your efforts @sanhaKimVics, I left some initial comments for you to consider.
0f9248d
to
7abbc17
Compare
@turkenf Any help to resolve this would be appreciated. |
/test-examples="examples/emr/v1beta1/cluster.yaml" |
Hi @sanhaKimVics, thank you for your patience here. Are you still interested in moving this PR forward? If so, please rebase your PR to the main, run make generate, and test the resources again. If you still get errors please let us know. |
Sure I'll rebase and do the test again thank you! |
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
… resources Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
…urce Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
c6fb19a
to
f940c39
Compare
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
config/emr/config.go
Outdated
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
}) | |
} | |
config.MoveToStatus(r.TerraformResource, "master_instance_fleet") | |
}) |
I'm replying to a runtime error reported in the Crossplane community Slack thread:
observe failed: cannot convert the singleton lists in the observed state value map into embedded objects: failed to convert between Crossplane and Terraform layers in mode "fromTerraform": cannot expand wildcards for the field path expression master_instance_fleet[*].launch_specifications: cannot expand wildcards for segments: "master_instance_fleet[*].launch_specifications": wildcard field "master_instance_fleet" is not found in the path
I don't have much experience with resource configuration, but moving master_instance_fleet
to status might be worth trying. Even if doing so wasn't not the right way to configure the resource, the result might tell more about how to address the issue.
Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
…aster_instance_fleet Signed-off-by: sanhaKimVics <[email protected]>
Signed-off-by: sanhaKimVics <[email protected]>
Adding emr_cluster, emr_instance_fleet, emr_instance_group resource.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Manually tested
Current issue with emr_cluster
While I was doing uptest e2e test with the cluster example, I faced this error after successful creation.