-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds derive from cel query readiness policy #247
feat: adds derive from cel query readiness policy #247
Conversation
244fc4e
to
c1feec7
Compare
c1feec7
to
c482567
Compare
@zach-source this looks great - do you have an example of how to reference a status condition with a specific |
I think I figured it out:
|
c482567
to
5d74eaa
Compare
Ah yea, exactly. And you can combine them if you want multiple. I've pushed up changes to make it pass all the reviewable checks. It's been a minute since I worked on a provider and I always have a hard time getting that submodule to sync correctly. You can see the list of all the available macros here: https://github.com/google/cel-spec/blob/master/doc/langdef.md#macros I'll add a test case for ya. |
@zach-source Please run |
2943164
to
3764119
Compare
Should be good to go now @bobh66 |
3764119
to
d875415
Compare
@turkenh can you take a look at this? It would be great to get this into the next release if possible - thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few minor comments
Thanks for the review - I'll do a bit of work on it this weekend and push it up. Probably tomorrow. |
d9f0694
to
e0857b8
Compare
@phisco comments have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! just a few small nits, we can address them in a follow up pr if needed
Signed-off-by: Zachary Taylor <[email protected]>
ddb432a
to
3c7299c
Compare
@phisco Added your recommended changes/nits. |
Description of your changes
Adds new readiness policy called "DeriveFromCelQuery". This policy allows the use of a cel query to check if an object is ready. This is handy to check conditions on objects with non-standard methods of determining if it ready such as the argocd applictation object.
Probably closes #192
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
I've written several test caes that cover the usage of the new feature.