Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Store Credentials Crossplane Support #33

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

satakshigarg
Copy link

Added the spec for object store credentials support for crossplane

satakshigarg added 7 commits September 12, 2022 18:40
Signed-off-by: satakshigarg <[email protected]>
Signed-off-by: satakshigarg <[email protected]>
Signed-off-by: satakshigarg <[email protected]>
Signed-off-by: satakshigarg <[email protected]>
Signed-off-by: satakshigarg <[email protected]>
Signed-off-by: satakshigarg <[email protected]>
Copy link
Collaborator

@vishalanarase vishalanarase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments other than that looks good

apis/template.go Outdated Show resolved Hide resolved
cmd/provider/main.go Outdated Show resolved Hide resolved
Signed-off-by: satakshigarg <[email protected]>
Signed-off-by: satakshigarg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants