refactor(TestSetterAndGetterTrait): Do not automatically set 'assert' to 'same' if value is an object #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 'same' if value is an object It was impossible to check a object values for equality without specifying the 'assert' method. This could have been unintuitive in certain test situations - while the opposite case ( check value objects to be the exact same) had not to be made explicit. Now checking if two value objects are the same has to be made explicit by specifying the assert method.
|
do I have todo something? |
|
@cbleek No I just realized, that this is a breaking change and therefor unfortunately is not suitable for a 2.x relase. It will have to wait for 3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was impossible to check a object values for equality without specifying the 'assert' method.
This could have been unintuitive in certain test situations - while the opposite case ( check value objects to be
the exact same) had not to be made explicit.
Now checking if two value objects are the same has to be made explicit by specifying the assert method.