feat(eslint-www): unused vars are error now

croquiscom · Dec 21, 2023 · 5414f0b · 5414f0b
1 parent 9933d79
commit 5414f0b
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 5 deletions.
diff --git a/.github/workflows/eslint-config-release.yml b/.github/workflows/eslint-config-release.yml
@@ -33,6 +33,7 @@ jobs:
         with:
           version: npm run changeset version
           publish: npm run release
+          title: 'chore(eslint): release x.y.z'
           cwd: ./TypeScript/eslint
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/.github/workflows/eslint-config-www-release.yml b/.github/workflows/eslint-config-www-release.yml
@@ -29,11 +29,11 @@ jobs:
         run: npm install
 
       - name: Create Release Pull Request or Publish to npm
-        id: changesets
         uses: changesets/action@v1
         with:
           version: npm run changeset version
           publish: npm run release
+          title: 'chore(eslint-www): release x.y.z'
           cwd: ./TypeScript/eslint-www
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/TypeScript/eslint-www/.changeset/config.json b/TypeScript/eslint-www/.changeset/config.json
@@ -1,7 +1,8 @@
 {
-  "$schema": "https://unpkg.com/@changesets/config@1.6.0/schema.json",
+  "$schema": "https://unpkg.com/@changesets/config@3.0.0/schema.json",
   "changelog": "@changesets/cli/changelog",
   "commit": false,
+  "fixed": [],
   "linked": [],
   "access": "public",
   "baseBranch": "main",

diff --git a/TypeScript/eslint-www/.changeset/fuzzy-colts-tie.md b/TypeScript/eslint-www/.changeset/fuzzy-colts-tie.md
@@ -0,0 +1,5 @@
+---
+'@croquiscom/eslint-config-www': minor
+---
+
+unused vars are error now
diff --git a/TypeScript/eslint-www/index.js b/TypeScript/eslint-www/index.js
@@ -336,10 +336,10 @@ module.exports = {
     // 불필요한 조건문 / operators를 사용하지 않는다
     '@typescript-eslint/no-unnecessary-condition': ['error', { allowConstantLoopConditions: true }],
 
-    // 사용하지 않는 변수를 경고한다. 단 _로 시작하는 변수는 무시한다.
+    // 사용하지 않는 변수를 허용하지 않는다. 단 _로 시작하는 변수는 무시한다.
     'no-unused-vars': 'off',
     '@typescript-eslint/no-unused-vars': [
-      'warn',
+      'error',
       {
         ignoreRestSiblings: true,
         varsIgnorePattern: '^_',

diff --git a/TypeScript/eslint-www/package.json b/TypeScript/eslint-www/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@croquiscom/eslint-config-www",
   "version": "2.5.0",
-  "description": "ESLint configuration used by Croquiscom www",
+  "description": "ESLint configuration used by Kakaostyle web projects",
   "main": "index.js",
   "repository": {
     "type": "git",