Skip to content

Commit

Permalink
feat(eslint, eslint-www): update dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
sixmen committed Dec 13, 2023
1 parent 459df96 commit 195362b
Show file tree
Hide file tree
Showing 10 changed files with 2,458 additions and 1,587 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/eslint-config-www-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Release eslint-config-www
on:
push:
branches:
- master
- main
paths:
- TypeScript/eslint-www/**
workflow_dispatch:
Expand All @@ -18,12 +18,12 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: Install Dependencies
run: npm install
Expand All @@ -37,5 +37,5 @@ jobs:
cwd: ./TypeScript/eslint-www
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
createGithubReleases: false
10 changes: 10 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"arrowParens": "always",
"endOfLine": "lf",
"jsxSingleQuote": true,
"printWidth": 120,
"quoteProps": "consistent",
"singleQuote": true,
"tabWidth": 2,
"trailingComma": "all"
}
2 changes: 1 addition & 1 deletion TypeScript/eslint-www/.changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"commit": false,
"linked": [],
"access": "public",
"baseBranch": "master",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": []
}
5 changes: 5 additions & 0 deletions TypeScript/eslint-www/.changeset/three-balloons-talk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@croquiscom/eslint-config-www': minor
---

update dependencies
6 changes: 3 additions & 3 deletions TypeScript/eslint-www/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ You can override the settings from `eslint-config-www` by editing the `.eslintrc

### PR

- master를 base 브랜치로 한 작업 브랜치를 생성합니다.
- main를 base 브랜치로 한 작업 브랜치를 생성합니다.
- 배포 및 버전관리를 changeset을 통해 관리하고 있습니다. PR 생성시 [changeset README.md](./.changeset/README.md) 문서를 참고하여 파일을 생성해주세요.

### 배포

Github Action을 통해 자동으로 배포하고 있습니다.

changeset 파일을 포함한 PR이 master에 머지되면, Github Action 워크플로우가 동작되며, 버전 배포를 위한 Version Packages PR이 생성됩니다.
changeset 파일을 포함한 PR이 main에 머지되면, Github Action 워크플로우가 동작되며, 버전 배포를 위한 Version Packages PR이 생성됩니다.
해당 PR을 머지하게 되면 Github Action의 워크플로우가 동작되며 패키지가 배포됩니다.

#### Github Action을 통한 배포가 불가능할 경우
Expand All @@ -49,7 +49,7 @@ npm run changeset version
git commit -m "chore: version bump"
```

- Version Packages PR이 생성되었을 경우 해당 PR을 머지하고 master를 최신 상태로 PULL 받아주세요.
- Version Packages PR이 생성되었을 경우 해당 PR을 머지하고 main를 최신 상태로 PULL 받아주세요.

```bash
npm run release
Expand Down
6 changes: 3 additions & 3 deletions TypeScript/eslint-www/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ module.exports = {
'no-useless-constructor': 'off',
'@typescript-eslint/no-useless-constructor': 'warn',

// https://github.com/benmosher/eslint-plugin-import/tree/master/docs/rules
// https://github.com/benmosher/eslint-plugin-import/tree/main/docs/rules
'import/first': 'error',
'import/no-amd': 'error',
'import/no-anonymous-default-export': 'off',
Expand Down Expand Up @@ -205,7 +205,7 @@ module.exports = {
'react/require-render-return': 'error',
'react/style-prop-object': 'warn',

// https://github.com/evcohen/eslint-plugin-jsx-a11y/tree/master/docs/rules
// https://github.com/evcohen/eslint-plugin-jsx-a11y/tree/main/docs/rules
'jsx-a11y/accessible-emoji': 'warn',
'jsx-a11y/alt-text': 'warn',
'jsx-a11y/anchor-has-content': 'warn',
Expand All @@ -230,7 +230,7 @@ module.exports = {
'jsx-a11y/role-supports-aria-props': 'warn',
'jsx-a11y/scope': 'warn',

// https://github.com/facebook/react/tree/master/packages/eslint-plugin-react-hooks
// https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'warn',

Expand Down
Loading

0 comments on commit 195362b

Please sign in to comment.