Replace itertools dependency with methods from the standard library#93
Open
jhorstmann wants to merge 1 commit into
Open
Replace itertools dependency with methods from the standard library#93jhorstmann wants to merge 1 commit into
jhorstmann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing a dependency audit we noticed that we had a dependency on an old version of
itertoolsexclusively throughcriterion. Looking at the code, it seemed relatively trivial to replace the dependency with methods from the standard library instead of bumping the dependency version.The
izipmacro is just a small wrapper around zipping multiple iterators, it only saves a tiny bit of code.A
chunk_bymethod was added to slices and stabilized in Rust 1.77. The method is slightly more generic, since it takes a comparison function instead of a key extractor.