Fix html_reports feature#86
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR restores html_reports as the switch that actually controls HTML report generation, making HTML-report-related deps truly optional and updating docs/tests to reflect the default-feature behavior.
Changes:
- Gate HTML-report code paths behind
feature = "html_reports"and makecriterion-plot/tinytemplateoptional deps enabled by that feature. - Add a regression test to ensure disabling
html_reportspreventsreport/output. - Update README/book docs and changelog to reflect the feature/defaults behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/criterion_tests.rs |
Adds a feature-gated regression test for absence of HTML report output. |
src/report.rs |
Guards the HTML reporter field and invocation behind html_reports. |
src/lib.rs |
Gates plotting modules/APIs behind html_reports and adds no-op APIs when disabled. |
book/src/user_guide/plots_and_graphs.md |
Updates guidance/examples around enabling/disabling HTML reports. |
book/src/user_guide/html_report.md |
Updates guidance/examples around enabling/disabling HTML reports. |
README.md |
Simplifies dependency snippet now that HTML reports are default-enabled. |
Cargo.toml |
Makes HTML-report deps optional and adds html_reports to default features. |
CHANGELOG.md |
Notes fix restoring html_reports control over report generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3d0ab95 to
4a65207
Compare
|
Making 'html_reports' a default feature goes beyond just fixing it. How about we add tests for the feature while keeping it non-default? |
Thanks for clarifying. I treated the issue suggestion’s “enable it by default” as part of the fix, I'll update it. |
4a65207 to
8802593
Compare
8802593 to
7330603
Compare
Fixes #56