Skip to content

Log-2 Axis Scale Plotting#64

Open
LebedevRI wants to merge 1 commit into
criterion-rs:masterfrom
LebedevRI:plot-axis-log2
Open

Log-2 Axis Scale Plotting#64
LebedevRI wants to merge 1 commit into
criterion-rs:masterfrom
LebedevRI:plot-axis-log2

Conversation

@LebedevRI

Copy link
Copy Markdown

Allow to use log-2 base for logarithmically-scaled axis.
I've tested this, (separately from cargo-criterion change),
i believe this works as expected, although things could be better,
e.g. when using gnuplot, the ticks labels are sometimes outputted
in %e format, with base=10, which looks, perhaps, suboptimal.

@LebedevRI LebedevRI force-pushed the plot-axis-log2 branch 2 times, most recently from f4926ff to 96d567b Compare March 5, 2026 05:00
Comment thread src/lib.rs
@LebedevRI LebedevRI requested a review from berkus April 26, 2026 19:42
@LebedevRI

Copy link
Copy Markdown
Author

@berkus Hi! Do you have anything in particular in mind as to what changes are still needed here?
I will be perfectly happy to deal with any number of nits,
but i don't know what they are, because nothing really stands out to me here...

@LebedevRI

LebedevRI commented Apr 28, 2026

Copy link
Copy Markdown
Author

<...>, although things could be better, e.g. when using gnuplot, the ticks labels are sometimes outputted in %e format, with base=10, which looks, perhaps, suboptimal.

So this is kind-of possible, #81,
but the more i look at plotting, the less i like existing backends.

Other than that, i'm not really aware of any pending touchups from my side.

This comment was marked as low quality.

@lemmih lemmih left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Can merge once the CHANGELOG has the entry under unreleased rather than under 0.8.2.

@berkus

berkus commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@LebedevRI please update the changelog line as @lemmih suggested and lets merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants