Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break out LLMs into their own dependency and tests #97

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Break out LLMs into their own dependency and tests #97

merged 1 commit into from
Oct 30, 2023

Conversation

pydanny
Copy link
Member

@pydanny pydanny commented Oct 30, 2023

This will speed up tests and also allows for experimental efforts like using the transformers library.

Changes:

  • Moved transformers and clarifai_rpg into their own dependency chains
  • Moved the tests into two categories so we can focus CI on their respective types
  • Documented how to install and test both

@pydanny
Break out LLMs into their own dependency and tests
4a66e98 
This will speed up tests and also allows for experimental efforts like using transformers.
audreyfeldroy
audreyfeldroy approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@audreyfeldroy audreyfeldroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a huge help! Thank you @pydanny 🙏

@audreyfeldroy audreyfeldroy merged commit 30321c5 into main Oct 30, 2023
4 checks passed
@audreyfeldroy audreyfeldroy deleted the seperate-llms branch October 30, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audreyfeldroy audreyfeldroy audreyfeldroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pydanny @audreyfeldroy