Skip to content

🎨 Palette: Improve accessibility of GoalsList buttons - #405

Open
criptogus wants to merge 1 commit into
mainfrom
palette-goals-accessibility-5611818276859633768
Open

🎨 Palette: Improve accessibility of GoalsList buttons#405
criptogus wants to merge 1 commit into
mainfrom
palette-goals-accessibility-5611818276859633768

Conversation

@criptogus

Copy link
Copy Markdown
Owner

💡 What: Added accessible names and keyboard focus visibility to GoalsList action buttons.
🎯 Why: Screen reader users could not identify the "Edit" and "Delete" buttons, and keyboard users could not see them when tabbing because they were only visible on hover.
♿ Accessibility:

  • Added aria-label and title to icon-only buttons.
  • Added group-focus-within:opacity-100 for keyboard visibility.
  • Verified with unit tests and visual inspection.

PR created automatically by Jules for task 5611818276859633768 started by @criptogus

- Added `aria-label` and `title` to "Edit" and "Delete" icon-only buttons in `GoalsList.tsx`.
- Added `group-focus-within:opacity-100` to the actions container to ensure buttons are visible when focused via keyboard navigation.
- Added a unit test `src/tests/components/GoalsList.test.tsx` to verify accessibility attributes.

Co-authored-by: criptogus <128640021+criptogus@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant