Skip to content

🎨 Palette: Improve accessibility of Goals List actions - #396

Open
criptogus wants to merge 1 commit into
mainfrom
palette-goals-accessibility-fix-11816094245647722084
Open

🎨 Palette: Improve accessibility of Goals List actions#396
criptogus wants to merge 1 commit into
mainfrom
palette-goals-accessibility-fix-11816094245647722084

Conversation

@criptogus

Copy link
Copy Markdown
Owner
  • 💡 What:
    • Added aria-label and title to "Edit" and "Delete" buttons in GoalsList component.
    • Added group-focus-within:opacity-100 to the actions container.
    • Added a unit test src/tests/components/GoalsList.test.tsx to verify these accessibility improvements.
  • 🎯 Why:
    • Previously, "Edit" and "Delete" actions were hidden until hovered, making them invisible and confusing for keyboard users.
    • The icon-only buttons lacked accessible names, making them unusable for screen reader users.
  • 📸 Before/After:
    • Before: Actions invisible on focus, no screen reader names.
    • After: Actions visible on focus, descriptive names for screen readers.
  • ♿ Accessibility:
    • Keyboard navigation: Controls now appear on focus.
    • Screen reader: Buttons now have "Editar meta" and "Excluir meta" labels.

PR created automatically by Jules for task 11816094245647722084 started by @criptogus

- Add `aria-label` and `title` to edit and delete buttons in GoalsList
- Add `group-focus-within:opacity-100` to ensure actions are visible on keyboard focus
- Add unit test to verify accessibility attributes and classes

Co-authored-by: criptogus <128640021+criptogus@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant