🛡️ Sentinel: [CRITICAL] Fix SSRF vulnerability in WebsiteAnalysisService redirects - #395
🛡️ Sentinel: [CRITICAL] Fix SSRF vulnerability in WebsiteAnalysisService redirects#395criptogus wants to merge 1 commit into
Conversation
…edirects - Disable automatic redirects in axios (`maxRedirects: 0`) - Implement manual redirect handling loop - Validate every URL in the redirect chain using `validateWebUrl` - Add security test `backend/tests/websiteAnalysisService.security.test.ts` to verify the fix Co-authored-by: criptogus <128640021+criptogus@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
This PR addresses a Critical SSRF vulnerability in
WebsiteAnalysisService. Previously,axioswas configured to follow redirects automatically, which allowed an attacker to bypass the initial URL validation by redirecting to a private IP (Time-of-Check to Time-of-Use).The fix implements manual redirect handling, ensuring that
validateWebUrlis called for every URL in the redirect chain before fetching.Verification:
backend/tests/websiteAnalysisService.security.test.tsconfirms that redirects to private IPs are blocked.backend/tests/website-integration.test.tsconfirm no regression in normal functionality.PR created automatically by Jules for task 6531322594347081047 started by @criptogus