Fix sidebar z-index stacking context in AppLayout - #387
Merged
Conversation
The sidebar links stopped working after navigating to Dashboard because the sidebar was inside a z-30 stacking context container. Dashboard's fixed inset-0 elements were interfering with click events due to the nested stacking context hierarchy. Fix: Move both desktop and mobile sidebar outside the z-30 container so they're at the root stacking context level (like the header at z-50). This ensures the sidebar's z-[45] is compared directly against other root-level elements, making links always clickable. https://claude.ai/code/session_01DQc3H42fPsRJbzRminACDF
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
Refactored the sidebar positioning in AppLayout to fix z-index stacking context issues. The sidebars (both desktop and mobile) are now rendered outside the main z-30 container, allowing them to properly layer above the main content without being constrained by the parent's stacking context.
Changes:
This ensures the sidebars maintain their intended z-index hierarchy regardless of the main content's positioning context.
🎯 Type of Change
📸 Screenshots
N/A - Layout/stacking fix
✅ Checklist
Code Quality
Testing
Documentation
🧪 How Has This Been Tested?
👀 Reviewer Notes
Areas needing special attention:
https://claude.ai/code/session_01DQc3H42fPsRJbzRminACDF