Skip to content

🎨 Palette: Improve GlobalSearchModal accessibility - #384

Open
criptogus wants to merge 1 commit into
mainfrom
palette-global-search-a11y-13938643083951283489
Open

🎨 Palette: Improve GlobalSearchModal accessibility#384
criptogus wants to merge 1 commit into
mainfrom
palette-global-search-a11y-13938643083951283489

Conversation

@criptogus

Copy link
Copy Markdown
Owner

💡 What:

  • Converted GlobalSearchModal search results from clickable divs to <button> elements.
  • Added explicit focus-visible styles for better keyboard navigation visibility.
  • Added <DialogDescription> to the modal for screen reader context and to resolve Radix UI warnings.

🎯 Why:

  • Search results were previously inaccessible to keyboard users (could not tab to them) and screen readers (announced as generic groups).
  • The modal was triggering accessibility warnings due to a missing description.

♿ Accessibility:

  • Keyboard: Users can now Tab through search results and select them with Enter/Space. Focus rings are now clearly visible.
  • Screen Readers: Results are announced as buttons. The modal purpose is now described via DialogDescription.

Testing:

  • Verified with pnpm test src/tests/components/GlobalSearchModal.test.tsx (new test added).
  • Visually verified focus states via screenshot.

PR created automatically by Jules for task 13938643083951283489 started by @criptogus

Co-authored-by: criptogus <128640021+criptogus@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant