fix: recycle option overrides vfs objects defined in the global section #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhal3d96
force-pushed
the
fix_recycle_option
branch
from
a0d22d7 to
f01048a
Compare
| echo "hide files = $(_jq '.hidefiles')" >> /etc/samba/smb.conf | ||
| fi | ||
| if [[ "$(_jq '.recycle')" != "null" ]] && [[ -n "$(_jq '.recycle')" ]]; then | ||
| if [[ "$(_jq '.recycle')" != "null" ]] && [[ "$(_jq '.recycle')" = "yes" ]]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
recyclefield value wasn't checked and it was always set with this small change it checks if it's set toyesand if so it appends its configuration to/etc/samba/smb.conf.This is crucial to make Samba works in write-mode with iOS.
"vfs objects = recycle"overrides the global configurationvfs objects = fruit streams_xattrfixes: #132