Support: Generalize one more use case into support.util.refresh_table
#140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/improve-refresh-after-dml
branch
from
ed91bab to
6c72868
Compare
seut
approved these changes
Jun 25, 2024
Member
seut
left a comment
seut
left a comment
There was a problem hiding this comment.
thx!
I think your approach with concrete argument signatures is also fine and eliminates the need for an optional table_schema argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion
@seut suggested another improvement at #28 (review):
Status
This patch refactors the auxiliary logic into
support.util.refresh_table, but doesn't do anything else yet, in order not to complicate the interface too quickly/early.Q&A
Maybe I am currently not seeing the spot for important improvements, which should be done right from the start: So, please advise if you still would like to introduce an optional schema name as function argument, and also please suggest further improvements you would like to see in this area.