Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Dec 10, 2025

@amotl
Copy link
Member Author

amotl commented Dec 10, 2025

@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Walkthrough

This PR updates Python version support across the project to version 3.14. Configuration changes span GitHub Actions workflows, project metadata in pyproject.toml, and changelog documentation. No functional code changes were made.

Changes

Cohort / File(s) Summary
GitHub Actions workflows
.github/workflows/_lint.yml, .github/workflows/_release.yml, .github/workflows/_test.yml, .github/workflows/_test_release.yml, .github/workflows/ci.yml
Updated Python runtime versions from 3.10, 3.11, or 3.13 to 3.14 across lint, test, release, and CI workflows. Matrix configurations and environment Python versions modified to target 3.14.
Project metadata and documentation
CHANGES.md, pyproject.toml
Added Python 3.14 to supported version classifiers in project configuration and documented support verification in the changelog.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

These are straightforward, repetitive configuration changes updating Python version numbers across workflow files and metadata. No logic modifications, complex interactions, or heterogeneous patterns requiring separate reasoning for each file.

Poem

🐰 Hopping forth to Python's newest shore,
Version 3.14—we code and explore!
Workflows, classifiers, all updated bright,
Each matrix tested, configs set right,
Our project hops into the future's light! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating CI workflows to use Python 3.14, which directly matches the changeset modifications across workflow files and project configuration.
Description check ✅ Passed The description appropriately explains the maintenance purpose of the PR and provides relevant references to Python 3.14 release information, which aligns with the changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch python314

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl requested review from seut and surister December 19, 2025 05:40
@amotl amotl marked this pull request as ready for review December 19, 2025 05:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
.github/workflows/_test.yml (1)

24-25: Consider retaining Python 3.13 in the test matrix until 3.14 support is confirmed.

Since the PR description mentions that the update currently fails with an upstream issue, replacing 3.13 with 3.14 removes the safety net of testing against a working recent Python version. Consider temporarily testing both:

 python-version:
   - "3.10"
+  - "3.13"
   - "3.14"

This allows CI to remain functional while Python 3.14 compatibility issues are resolved. Once 3.14 is fully working, 3.13 can be removed.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22d2091 and ac9e72f.

📒 Files selected for processing (7)
  • .github/workflows/_lint.yml (1 hunks)
  • .github/workflows/_release.yml (1 hunks)
  • .github/workflows/_test.yml (1 hunks)
  • .github/workflows/_test_release.yml (1 hunks)
  • .github/workflows/ci.yml (1 hunks)
  • CHANGES.md (1 hunks)
  • pyproject.toml (1 hunks)
🔇 Additional comments (4)
.github/workflows/ci.yml (1)

33-33: Python version update looks good for the build job.

The update to Python 3.14 for the diff-checking build job is appropriate. Since this job only runs the check_diff.py script and doesn't execute tests or build packages, the Python 3.14 requirement should be straightforward.

.github/workflows/_lint.yml (1)

33-34: Python 3.14 update aligns with project goals.

The lint matrix update is consistent with the PR objectives. Linting on min (3.10) and max (3.14) versions is a reasonable strategy per the inline comments.

Note: If Python 3.14 compatibility issues persist (per the upstream issue mentioned in the PR), you may want to temporarily retain 3.13 in the matrix to keep CI functional.

.github/workflows/_test_release.yml (1)

13-13: Test release workflow update may block releases until Python 3.14 is fully supported.

The update to Python 3.14 in the release test workflow is appropriate long-term. However, given the known compatibility issues mentioned in the PR, this workflow will fail until upstream dependencies support Python 3.14. This could block the release process.

Consider whether to merge this PR before or after resolving the upstream issue at langchain-ai/langchain#34291.

.github/workflows/_release.yml (1)

19-19: Production release workflow update requires working Python 3.14 support.

The update to Python 3.14 in the production release workflow is consistent with the PR objectives. However, this workflow is used for actual PyPI releases, so it must be fully functional.

Ensure that the upstream compatibility issues (langchain-ai/langchain#34291) are resolved before merging this change, or production releases will be blocked.

# LangChain CrateDB Adapter Changelog

## Unreleased
- Verified support for Python 3.14
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Changelog entry is inconsistent with PR status.

The entry states "Verified support for Python 3.14," but the PR description indicates that the update currently fails with an upstream issue. Consider rewording this to reflect the work-in-progress status:

-- Verified support for Python 3.14
+- Add Python 3.14 support (pending upstream dependency updates)

or remove this entry until support is actually verified and working.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Verified support for Python 3.14
- Add Python 3.14 support (pending upstream dependency updates)
🤖 Prompt for AI Agents
In CHANGES.md around line 4, the changelog line "Verified support for Python
3.14" is inconsistent with the PR which states the update currently fails due to
an upstream issue; change the entry to reflect work-in-progress or remove it.
Either replace the line with a WIP phrasing such as "Work in progress: attempted
Python 3.14 support (blocked by upstream issue #XYZ)" including the issue
reference, or delete the entry until support is fully verified and passing.

@amotl amotl merged commit e46cfe0 into main Dec 20, 2025
10 checks passed
@amotl amotl deleted the python314 branch December 20, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants