-
Notifications
You must be signed in to change notification settings - Fork 0
CI: Use Python 3.14 across the board #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The update currently fails. We've reported it upstream. |
WalkthroughThis PR updates Python version support across the project to version 3.14. Configuration changes span GitHub Actions workflows, project metadata in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes These are straightforward, repetitive configuration changes updating Python version numbers across workflow files and metadata. No logic modifications, complex interactions, or heterogeneous patterns requiring separate reasoning for each file. Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/_test.yml (1)
24-25: Consider retaining Python 3.13 in the test matrix until 3.14 support is confirmed.Since the PR description mentions that the update currently fails with an upstream issue, replacing 3.13 with 3.14 removes the safety net of testing against a working recent Python version. Consider temporarily testing both:
python-version: - "3.10" + - "3.13" - "3.14"This allows CI to remain functional while Python 3.14 compatibility issues are resolved. Once 3.14 is fully working, 3.13 can be removed.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.github/workflows/_lint.yml(1 hunks).github/workflows/_release.yml(1 hunks).github/workflows/_test.yml(1 hunks).github/workflows/_test_release.yml(1 hunks).github/workflows/ci.yml(1 hunks)CHANGES.md(1 hunks)pyproject.toml(1 hunks)
🔇 Additional comments (4)
.github/workflows/ci.yml (1)
33-33: Python version update looks good for the build job.The update to Python 3.14 for the diff-checking build job is appropriate. Since this job only runs the
check_diff.pyscript and doesn't execute tests or build packages, the Python 3.14 requirement should be straightforward..github/workflows/_lint.yml (1)
33-34: Python 3.14 update aligns with project goals.The lint matrix update is consistent with the PR objectives. Linting on min (3.10) and max (3.14) versions is a reasonable strategy per the inline comments.
Note: If Python 3.14 compatibility issues persist (per the upstream issue mentioned in the PR), you may want to temporarily retain 3.13 in the matrix to keep CI functional.
.github/workflows/_test_release.yml (1)
13-13: Test release workflow update may block releases until Python 3.14 is fully supported.The update to Python 3.14 in the release test workflow is appropriate long-term. However, given the known compatibility issues mentioned in the PR, this workflow will fail until upstream dependencies support Python 3.14. This could block the release process.
Consider whether to merge this PR before or after resolving the upstream issue at langchain-ai/langchain#34291.
.github/workflows/_release.yml (1)
19-19: Production release workflow update requires working Python 3.14 support.The update to Python 3.14 in the production release workflow is consistent with the PR objectives. However, this workflow is used for actual PyPI releases, so it must be fully functional.
Ensure that the upstream compatibility issues (langchain-ai/langchain#34291) are resolved before merging this change, or production releases will be blocked.
| # LangChain CrateDB Adapter Changelog | ||
|
|
||
| ## Unreleased | ||
| - Verified support for Python 3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entry is inconsistent with PR status.
The entry states "Verified support for Python 3.14," but the PR description indicates that the update currently fails with an upstream issue. Consider rewording this to reflect the work-in-progress status:
-- Verified support for Python 3.14
+- Add Python 3.14 support (pending upstream dependency updates)or remove this entry until support is actually verified and working.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Verified support for Python 3.14 | |
| - Add Python 3.14 support (pending upstream dependency updates) |
🤖 Prompt for AI Agents
In CHANGES.md around line 4, the changelog line "Verified support for Python
3.14" is inconsistent with the PR which states the update currently fails due to
an upstream issue; change the entry to reflect work-in-progress or remove it.
Either replace the line with a WIP phrasing such as "Work in progress: attempted
Python 3.14 support (blocked by upstream issue #XYZ)" including the issue
reference, or delete the entry until support is fully verified and passing.
About
Just maintenance. Python 3.14 was released on Oct. 7, 2025.
References