-
Notifications
You must be signed in to change notification settings - Fork 1
Connect: Improve guidance re. learning path and reference styles #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix missing link reference for BLOB support.
The bullet links to
[CrateDB BLOBs]
, but no reference definition exists, so the docs build/lint fails (MD052). Add the missing definition (pointing to the correct target) alongside the other references at the end of the file.[PostgreSQL interface]: inv:crate-reference:*:label#interface-postgresql [SQL query syntax]: inv:crate-reference:*:label#sql +[CrateDB BLOBs]: inv:crate-reference:*:label#blob-support
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
159-159: Reference links and images should use a label that is defined
Missing link or image reference definition: "cratedb blobs"
(MD052, reference-links-images)
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai: It is included in
links.md
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 57
@amotl, you're absolutely right! I apologize for the incorrect review comment. I can confirm that
[CrateDB BLOBs]
is indeed defined indocs/_include/links.md
:Since the file is included at the top of the document with
:::{include} /_include/links.md
, the reference is available throughout the document. The markdownlint warning (MD052) appears to be a false positive, likely because the linter doesn't fully process the include directive when checking references.The code is correct as-is. Would you like me to resolve my previous review comment?