-
Notifications
You must be signed in to change notification settings - Fork 1
Usage guides: Use {Docker,Podman} Compose where applicable #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRefactors many integration docs to use Docker/Podman Compose: adds/updates compose.yaml files, rewrites usage guides to a compose-centric workflow, normalizes examples (CRATE_HEAP_SIZE=1g), removes explicit single-node flags, and adds small CLI/tool services and helper volumes where needed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant Compose as "Docker/Podman Compose"
participant CrateDB
participant Broker as "Integration Broker/DB"
participant Tool as "CLI/Tool (ctk/amqpcat/nc/uv)"
User->>Compose: docker compose up
Compose->>CrateDB: start cratedb (HTTP healthcheck)
Compose->>Broker: start broker/db (depends_on)
Note over CrateDB,Broker: services wait on cratedb healthcheck
User->>Compose: docker compose run --rm Tool submit
Tool->>Broker: produce/ingest data
Broker->>CrateDB: forward/write data
User->>Compose: docker compose exec cratedb psql / query
CrateDB-->>User: query results
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
It is better for Windows users.
It is better for "Docker on Windows" users.
8bed5de
to
b37dcb5
Compare
b37dcb5
to
8125152
Compare
psql "postgresql://crate:crate@cratedb:5432/" <<SQL | ||
docker compose run --rm --no-TTY psql psql "postgresql://crate:crate@cratedb:5432/" <<SQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
psql psql
reads like a typo to some. Maybe let's rename the first fragment (Docker Compose service name), which is at our disposal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 6e258d9.
docs/integrate/mongodb/usage.md
Outdated
mongosh --host mongodb --db test --eval 'db.demo.insert({"temperature": 42.84, "humidity": 83.1})' | ||
docker compose run --rm --no-TTY mongosh mongosh --host mongodb --db test --eval 'db.demo.insert({"temperature": 42.84, "humidity": 83.1})' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dito.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 6e258d9.
docs/integrate/mongodb/usage.md
Outdated
ctk load table \ | ||
"mongodb://mongodb/test/demo" \ | ||
--cluster-url="crate://cratedb/doc/mongodb_demo" | ||
docker compose run --rm --no-TTY ctk ctk load table "mongodb://mongodb/test/demo" --cluster-url="crate://cratedb/doc/mongodb_demo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dito.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 6e258d9.
# Service composition file for Docker Compose or Podman Compose | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add a reference URL to the very documentation slot? Relevant are the compose.yaml
files and any other configuration files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 1d14227.
49771fd
to
59dd261
Compare
When they are identical, they might as a typo to some.
This gives users more orientation after downloading usage guide assets.
About
By using {Docker,Podman} Compose, a significant amount of code and configuration noise can be reduced on the prose document, but maintained within a
compose.yaml
file instead. It aims to improve usability and might also open the door for automated testing within a reasonable range of efforts.References
-Cdiscovery.type=single-node
#325crash
#328