Skip to content

Conversation

amotl
Copy link
Member

@amotl amotl commented Aug 13, 2025

About

A sweeping update to use a different file name for the tutorial pages: tutorial{.md,.rst}.

Preview

Not much to "see" here. -- https://cratedb-guide--250.org.readthedocs.build/integrate/

References

@amotl amotl added sanding-1200 Fine sanding. refactoring Changing shape or layout, or moving content around. labels Aug 13, 2025
Copy link

coderabbitai bot commented Aug 13, 2025

Warning

Rate limit exceeded

@amotl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c27d627 and db89bb5.

📒 Files selected for processing (18)
  • docs/feature/document/index.md (1 hunks)
  • docs/feature/search/fts/index.md (1 hunks)
  • docs/integrate/azure-functions/index.md (2 hunks)
  • docs/integrate/azure-functions/tutorial.rst (1 hunks)
  • docs/integrate/dbt/index.md (2 hunks)
  • docs/integrate/dbt/tutorial.md (1 hunks)
  • docs/integrate/grafana/index.md (2 hunks)
  • docs/integrate/grafana/tutorial.rst (1 hunks)
  • docs/integrate/influxdb/index.md (2 hunks)
  • docs/integrate/influxdb/tutorial.md (1 hunks)
  • docs/integrate/marquez/index.md (2 hunks)
  • docs/integrate/marquez/tutorial.md (1 hunks)
  • docs/integrate/metabase/index.md (2 hunks)
  • docs/integrate/metabase/tutorial.rst (1 hunks)
  • docs/integrate/mongodb/index.md (2 hunks)
  • docs/integrate/mongodb/tutorial.md (1 hunks)
  • docs/integrate/streamsets/index.md (2 hunks)
  • docs/integrate/streamsets/tutorial.rst (1 hunks)

Walkthrough

Documentation navigation updated by replacing “learn” toctree entries with “Tutorial ” across multiple index pages. One page (dbt) also adds a brief “Usage guidelines, notes, and advanced configuration options.” content block. No code, APIs, or logic changed.

Changes

Cohort / File(s) Summary of Changes
Feature docs toctree relabeling
docs/feature/document/index.md, docs/feature/search/fts/index.md
In hidden toctree blocks, replaced learn with Tutorial <tutorial>.
Integrations toctree relabeling (single files)
docs/integrate/azure-functions/index.md, docs/integrate/grafana/index.md, docs/integrate/influxdb/index.md, docs/integrate/marquez/index.md, docs/integrate/mongodb/index.md, docs/integrate/streamsets/index.md
In hidden toctree blocks, replaced learn with Tutorial <tutorial>.
Integrations toctree relabeling (multiple occurrences)
docs/integrate/metabase/index.md
Replaced two learn entries with Tutorial <tutorial> in hidden toctree blocks.
DBT docs relabeling + content addition
docs/integrate/dbt/index.md
Replaced usage with Tutorial <tutorial> in toctree and added a short content block: “Usage guidelines, notes, and advanced configuration options.”

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

Possibly related PRs

Suggested labels

maintenance

Suggested reviewers

  • hammerhead
  • bmunkholm
  • karynzv
  • surister

Poem

A rabbit hops through pages bright,
Swapping "learn" for "Tutorial" light.
One small note for dbt I tuck away,
Carrots of clarity guide the way.
Thump-thump, docs aligned — hip hip hooray! 🥕

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch layout-learn-tutorial

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amotl amotl changed the title Naming things: learn.md -> tutorial.md Naming things: {learn,usage}.md -> tutorial.md Aug 13, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea49305 and 8009e8c.

📒 Files selected for processing (10)
  • docs/feature/document/index.md (1 hunks)
  • docs/feature/search/fts/index.md (1 hunks)
  • docs/integrate/azure-functions/index.md (1 hunks)
  • docs/integrate/dbt/index.md (1 hunks)
  • docs/integrate/grafana/index.md (1 hunks)
  • docs/integrate/influxdb/index.md (1 hunks)
  • docs/integrate/marquez/index.md (1 hunks)
  • docs/integrate/metabase/index.md (1 hunks)
  • docs/integrate/mongodb/index.md (1 hunks)
  • docs/integrate/streamsets/index.md (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: amotl
PR: crate/cratedb-guide#238
File: docs/integrate/azure-functions/learn.rst:1-1
Timestamp: 2025-08-09T16:19:43.966Z
Learning: In the CrateDB Guide documentation, main integration anchors (e.g., `azure-functions`) are intentionally placed in the `index.md` files of their respective integration folders, while detailed tutorials use the `-learn` suffix (e.g., `azure-functions-learn`) in their `learn.rst` or `learn.md` files. This is a deliberate architectural pattern for the documentation restructuring.
📚 Learning: 2025-08-09T16:19:43.966Z
Learnt from: amotl
PR: crate/cratedb-guide#238
File: docs/integrate/azure-functions/learn.rst:1-1
Timestamp: 2025-08-09T16:19:43.966Z
Learning: In the CrateDB Guide documentation, main integration anchors (e.g., `azure-functions`) are intentionally placed in the `index.md` files of their respective integration folders, while detailed tutorials use the `-learn` suffix (e.g., `azure-functions-learn`) in their `learn.rst` or `learn.md` files. This is a deliberate architectural pattern for the documentation restructuring.

Applied to files:

  • docs/integrate/influxdb/index.md
  • docs/integrate/azure-functions/index.md
  • docs/integrate/grafana/index.md
  • docs/integrate/mongodb/index.md
  • docs/integrate/streamsets/index.md
  • docs/integrate/dbt/index.md
🪛 LanguageTool
docs/integrate/metabase/index.md

[grammar] ~72-~72: There might be a mistake here.
Context: ...maxdepth: 1 :hidden: Tutorial ::: ```{seealso} [CrateDB and Metabase]...

(QB_NEW_EN)

docs/integrate/influxdb/index.md

[grammar] ~66-~66: There might be a mistake here.
Context: ...maxdepth: 1 :hidden: Tutorial :::

(QB_NEW_EN)

docs/integrate/marquez/index.md

[grammar] ~45-~45: There might be a mistake here.
Context: ...::{toctree} :hidden: Tutorial ::: [Marquez]: https://marquezproject....

(QB_NEW_EN)

docs/feature/search/fts/index.md

[grammar] ~377-~377: There might be a mistake here.
Context: ...n: options analyzer Tutorial ::: [BM25: The Next Generation of Luce...

(QB_NEW_EN)

docs/integrate/azure-functions/index.md

[grammar] ~45-~45: There might be a mistake here.
Context: ...maxdepth: 1 :hidden: Tutorial ::: [Azure Functions]: https://azure.m...

(QB_NEW_EN)

docs/integrate/grafana/index.md

[grammar] ~58-~58: There might be a mistake here.
Context: ...maxdepth: 1 :hidden: Tutorial ::: ```{seealso} [CrateDB and Grafana]...

(QB_NEW_EN)

docs/integrate/mongodb/index.md

[grammar] ~96-~96: There might be a mistake here.
Context: ...maxdepth: 1 :hidden: Tutorial ::: :::{seealso} Blog: [Announcing...

(QB_NEW_EN)

docs/integrate/streamsets/index.md

[grammar] ~39-~39: There might be a mistake here.
Context: ...maxdepth: 1 :hidden: Tutorial ::: [StreamSets Data Collector]: https:...

(QB_NEW_EN)

🔇 Additional comments (11)
docs/integrate/influxdb/index.md (1)

66-66: Update looks good — tutorial and legacy label verified

  • docs/integrate/influxdb/tutorial.md — present; contains the legacy label (influxdb-learn)= on line 1.

No further action required.

docs/integrate/grafana/index.md (1)

58-58: Tutorial target exists — please run the docs build to confirm resolution

Found the target file; please confirm the Sphinx build resolves the toctree entry.

  • docs/integrate/grafana/index.md — toctree entry: Tutorial <tutorial>
  • docs/integrate/grafana/tutorial.rst — verified present

Snippet:

Tutorial <tutorial>
docs/integrate/mongodb/index.md (1)

96-96: Tutorial exists and legacy label retained — no action required

The tutorial file docs/integrate/mongodb/tutorial.md exists and contains the legacy label (mongodb-learn)= on line 5, so the toctree/grid-card refs are correct.

  • docs/integrate/mongodb/tutorial.md — (mongodb-learn)= at line 5
docs/feature/document/index.md (1)

430-431: Toctree label/target update looks good.

Switching to "Tutorial " aligns with the PR objective and MyST/Sphinx toctree syntax.

docs/feature/search/fts/index.md (1)

377-378: Toctree updated correctly to “Tutorial ”.

The change is syntactically correct within the existing toctree block. No further issues spotted here.

docs/integrate/marquez/index.md (2)

45-46: Toctree entry update looks correct.

Hidden toctree now points to the tutorial target as intended.


34-39: No change required — marquez-learn label is present

docs/integrate/marquez/tutorial.md starts with (marquez-learn)=, so the 🔗 marquez-learn in docs/integrate/marquez/index.md is valid.

Files with other :link: *-learn occurrences (recommend scanning those targets):

  • docs/integrate/streamsets/index.md
  • docs/integrate/azure-functions/index.md
  • docs/integrate/mongodb/index.md
  • docs/integrate/marquez/index.md
  • docs/integrate/influxdb/index.md

If you want, I can scan the corresponding tutorial files and prepare a patch to replace any missing legacy labels or convert links to doc-by-name.

Likely an incorrect or invalid review comment.

docs/integrate/streamsets/index.md (2)

39-40: Toctree entry update is correct.

The hidden toctree now targets the tutorial page as per the naming change.


27-33: Card link is valid — no change required

Verified that the tutorial defines the anchor and the index references it, so the card link will resolve.

  • docs/integrate/streamsets/tutorial.rst — contains .. _streamsets-learn: (line 1)
  • docs/integrate/streamsets/index.md — uses :link: streamsets-learn (line 28)

Remove the suggested doc-name diff; keep the existing :link: streamsets-learn as-is.

docs/integrate/dbt/index.md (2)

145-149: Toctree re-targeting and new content block look good.

  • Swapping to “Tutorial ” is correct.
  • The “+++” separator for card body content is valid in sphinx-design and reads well.

131-140: No change required — legacy anchor preserved

Found (dbt-usage)= in docs/integrate/dbt/tutorial.md:1, so the 🔗 dbt-usage (ref) in docs/integrate/dbt/index.md is valid — no update needed.

  • docs/integrate/dbt/tutorial.md:1 — contains "(dbt-usage)="
  • docs/integrate/dbt/index.md: ~132 — grid-item-card uses ":link: dbt-usage" (ref)

Do not apply the suggested refactor; keep the existing anchor and link as-is.

@amotl amotl requested review from bmunkholm and kneth August 13, 2025 21:00
@amotl amotl marked this pull request as ready for review August 13, 2025 21:00
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed rewrite rule.

rewrite ^/docs/guide/integrate/(.*)/(learn|usage).html$                     /docs/guide/integrate/$1/tutorial.html           redirect;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the set of redirects for the current iteration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed rewrite rule.

rewrite ^/docs/guide/feature/(.*)/(learn|usage).html$                     /docs/guide/feature/$1/tutorial.html           redirect;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the set of redirects for the current iteration.

@amotl amotl force-pushed the layout-integrate-strip-prefix branch from ea49305 to f6223a3 Compare August 14, 2025 00:38
Copy link
Contributor

@bmunkholm bmunkholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realize it was so pervasive when I suggested the name change :-).
Thanks a bunch!

@amotl
Copy link
Member Author

amotl commented Aug 14, 2025

It's good that we nailed the "naming things" for this particular detail. However, a few questions on harmonization details remain, and I would love to present them to you to possibly receive a pragmatic decision out of it. 1 Thanks!

Footnotes

  1. Rationale: Providing an excellent layout and good rails on the "naming things" details tremendously helps others approaching the repository without prior knowledge. I think it is excellent that we invest time now, and I would like to get all the most prominent spots nailed in this regard, and within the very same work package. I think this resonates with @zolbatar's comment that, if a good template exists, it will be less work for the content author to populate it. Thanks!

@amotl amotl force-pushed the layout-integrate-strip-prefix branch from 96ab2bb to 2426269 Compare August 14, 2025 11:23
@amotl amotl added the guidance Matters of layout, shape, and structure. label Aug 14, 2025
Base automatically changed from layout-integrate-strip-prefix to main August 14, 2025 11:41
@amotl amotl force-pushed the layout-learn-tutorial branch from 8009e8c to c27d627 Compare August 14, 2025 11:42
@amotl amotl force-pushed the layout-learn-tutorial branch from c27d627 to db89bb5 Compare August 14, 2025 11:53
Copy link
Member

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed not much to see 😄

@amotl amotl merged commit 01fa3fa into main Aug 14, 2025
2 of 3 checks passed
@amotl amotl deleted the layout-learn-tutorial branch August 14, 2025 11:59
This was referenced Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

guidance Matters of layout, shape, and structure. refactoring Changing shape or layout, or moving content around. sanding-1200 Fine sanding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants