Skip to content

CI: Fix CodeQL and Release jobs #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amotl merged 1 commit into from
Nov 7, 2024
Merged

CI: Fix CodeQL and Release jobs #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ jobs:

strategy:
fail-fast: false
language: [ python ]
matrix:
language: [ python ]
Comment on lines -31 to +32
Copy link
Member Author

@amotl amotl Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the release procedure, but didn't see it previously. It looks like GitHub had been lenient on a previous wrong definition here, but stopped being so.

Invalid workflow file: .github/workflows/codeql.yml#L31
The workflow is not valid. .github/workflows/codeql.yml (Line: 31, Col: 7): Unexpected value 'language'

-- https://github.com/crate/crate-python/actions/runs/11703225760


steps:
- name: Checkout
Expand Down Expand Up @@ -58,7 +59,7 @@ jobs:

- name: Install project
run: |
uv pip install --editable=.[test]
uv pip install --system '.[test]'

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

- name: Build package
run: |
uv pip install build twine wheel
uv pip install --system build twine wheel
Copy link
Member Author

@amotl amotl Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's a hiccup from my previous "improvements".

error: No virtual environment found; run `uv venv` to create an environment, or pass `--system` to install into a non-virtual environment
Error: Process completed with exit code 2.

-- https://github.com/crate/crate-python/actions/runs/11703279293/job/32593274764#step:5:14

python -m build
twine check dist/*

Expand Down
Loading