gtk.cfg: Fix gtk_widget_destroy definition and usage

[Tamaranch]

gtk_widget_destroy is only for GtkWidget derived objects.

[chrchr-github]

Please add a (simple) example using gtk_widget_destroy() in gtk.c.

[Tamaranch]

Please add a (simple) example using gtk_widget_destroy() in gtk.c.

Done. I also removed duplicate definition of gtk_widget_destroy and added definition of gtk_window_new for proper test.

[chrchr-github]

The value of GTK_WINDOW_TOPLEVEL seems to be documented, so you could add it to gtk.cfg to fix the CI failure.

[Tamaranch]

The value of GTK_WINDOW_TOPLEVEL seems to be documented, so you could add it to gtk.cfg to fix the CI failure.

I wasn't notified for the CI failure, sorry. (err: now I am :))

[danmar]

I am no expert but when I ask chatgpt it says:

GTK 3
Using gtk_widget_destroy() is standard and commonly used.

GTK 4
GTK 4 documentation removed gtk_widget_destroy(). In GTK 4, widgets are generally disposed of by:

• Removing them from their parent, or
• Calling g_object_unref() if you own an extra reference

As I interpret it, this change might cause false positives for regular fine GTK 4 code.

[Tamaranch]

I am no expert but when I ask chatgpt it says:

GTK 3
Using gtk_widget_destroy() is standard and commonly used.
GTK 4
GTK 4 documentation removed gtk_widget_destroy(). In GTK 4, widgets are generally disposed of by:

• Removing them from their parent, or
• Calling g_object_unref() if you own an extra reference

As I interpret it, this change might cause false positives for regular fine GTK 4 code.

Yes you're right, I added the definition of gtk_window_destroy too.

[Tamaranch]

Oh wait, we'll have another issue: gtk_window_new doesn't take any parameter in gtk4…

• https://docs.gtk.org/gtk4/ctor.Window.new.html
• https://docs.gtk.org/gtk3/ctor.Window.new.html

Should we really add a test for gtk_widget_destroy here?

[danmar]

I fear that if you use gtk_window_new to allocate and then g_object_unref() to destroy the object you get a false positive about mismatching allocation and deallocation?