Skip to content

fix: deduplicate inherited members #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: deduplicate inherited members #722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/Metadata/Interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ class TrancheBuilder
std::vector<SymbolID>& M,
const Info& I)
{
M.emplace_back(I.id);
if(std::ranges::find(M, I.id) == M.end())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this ensure we take the right inherited member, though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alandefreitas All this does is ensure that elements in the tranche are unique.

Copy link
Collaborator

@alandefreitas alandefreitas Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, let's at least open another issue about ensuring dominance

M.emplace_back(I.id);
}

template<typename ListTy>
Expand Down
Loading