Skip to content

fix: support SFINAE detection for compound types #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: support SFINAE detection for compound types #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/lib/AST/ASTVisitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1876,6 +1876,9 @@ class ASTVisitor
std::optional<std::pair<QualType, std::vector<TemplateArgument>>>
isSFINAEType(QualType T)
{
if(! config_->detectSfinae)
return std::nullopt;

auto sfinae_info = getSFINAETemplate(T, true);
if(! sfinae_info)
return std::nullopt;
Expand Down Expand Up @@ -1904,6 +1907,12 @@ class ASTVisitor
return std::make_pair(param_arg->getAsType(), std::move(ControllingArgs));
}

std::optional<std::pair<QualType, std::vector<TemplateArgument>>>
isSFINAEType(const Type* T)
{
return isSFINAEType(QualType(T, 0));
}

std::string extractName(DeclarationName N)
{
std::string result;
Expand Down Expand Up @@ -3849,6 +3858,9 @@ class TerminalTypeVisitor
VisitDependentNameType(
const DependentNameType* T)
{
if(auto SFINAE = getASTVisitor().isSFINAEType(T); SFINAE.has_value())
return getDerived().Visit(SFINAE->first);

if(auto* NNS = T->getQualifier())
NNS_ = NNS;
getDerived().buildTerminal(NNS_, T->getIdentifier(),
Expand All @@ -3871,6 +3883,9 @@ class TerminalTypeVisitor
VisitTemplateSpecializationType(
const TemplateSpecializationType* T)
{
if(auto SFINAE = getASTVisitor().isSFINAEType(T); SFINAE.has_value())
return getDerived().Visit(SFINAE->first);

TemplateName TN = T->getTemplateName();
MRDOCS_ASSERT(! TN.isNull());
NamedDecl* ND = TN.getAsTemplateDecl();
Expand Down Expand Up @@ -4296,13 +4311,6 @@ buildTypeInfo(
ExtractionScope scope = enterMode(extract_mode);
// build the TypeInfo representation for the type
TypeInfoBuilder Builder(*this);

if(config_->detectSfinae)
{
if(auto SFINAE = isSFINAEType(qt); SFINAE.has_value())
qt = SFINAE->first.withFastQualifiers(qt.getLocalFastQualifiers());
}

Builder.Visit(qt);
return Builder.result();
}
Expand Down
Loading