Skip to content

Conversation

@julioest
Copy link
Contributor

  • Set a consistent blue background color to home page and antora documentation
  • Remove footer's li broken css rule

Preview
Screenshot 2025-10-30 at 5 14 06 PM

@julioest julioest requested a review from rbbeeston October 30, 2025 21:15
@cppalliance-bot
Copy link

cppalliance-bot commented Oct 30, 2025

An automated preview of the documentation is available at https://1101.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-10-30 22:41:56 UTC

@alandefreitas
Copy link
Collaborator

Looks really nice 😊 It also looks great visually 💙

Since we don’t have the gradient anymore, maybe it’d be a good idea to extend the blue background from the main content area so it matches the same blue used behind the breadcrumbs (which are currently a bit lighter)? 🤔

There’s just one small thing about the “style” tag in commits I used to get confused by that, because in web projects it can seem like “style” is meant for CSS changes, while other commit types are for the backend. But that threw me off since lots of non-web projects use that tag as well. And even CSS-heavy projects don’t use “style” for everything, which made it even more confusing 😅

After digging into it a bit more, I found that the “style” tag is usually for non-functional code changes — things like formatting/linting. The idea is to keep those commits separate so they don’t end up in the changelog. CSS-related changes, on the other hand, use whatever tag matches their scope in the project. In our case, that’d be “docs” ❤️

(That's just a comment for future PRs. Don't worry too much about it)

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.30%. Comparing base (33d985c) to head (ca35aff).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
- Coverage    85.30%   85.30%   -0.01%     
===========================================
  Files          306      306              
  Lines        22427    22426       -1     
===========================================
- Hits         19132    19131       -1     
  Misses        3295     3295              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julioest julioest force-pushed the ui/remove-gradient-bg branch from 1a8246e to ca35aff Compare October 30, 2025 22:31
@julioest julioest changed the title style: update background styles and color variables docs: remove gradients, use solid background, and clean up styles Oct 30, 2025
@julioest
Copy link
Contributor Author

I appreciate the clarity regarding the commit + tags best practices 🙏

@julioest julioest merged commit 86ce271 into cppalliance:develop Oct 31, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants