-
Notifications
You must be signed in to change notification settings - Fork 22
Drop stubs #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Drop stubs #1030
Conversation
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
2 similar comments
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
1 similar comment
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://1030.mrdocs.prtest2.cppalliance.org/index.html |
Oh... This drops not only the stubs but the whole libcxx library from the MrDocs installation. I understand how this option can be inconvenient. You run your project on Windows and Linux, but then it has some errors on MrDocs because the stubs are different or are missing some system library function. Still, that's a bold proposal, especially considering this is just an option. Many engineers spent months implementing and maintaining this because, as you are probably already noticing in CI, using MrDocs without this feature is hell. We seen how things are like without it, and we've been keeping it for good reason. Even though some projects might find it annoying because they get errors before they turn off the libc stubs, most other projects are avoiding lots of mistakes with reproducible builds and don't even notice it. Even the projects that turned off libc stubs are still using the libcxx headers and probably don't even know about it. In a sense, I understand why it isn't very pleasant. This feature is like plastic surgery; you notice the ones that didn't work. While I'm not emotionally attached to code at all, I have two obvious questions:
In the Boost release, without stable stubs, MrDocs can give you different results when you change it to an environment you haven't tested yet. Even small changes in the system could break it, because of how the process interacts with CMake and everything. And you don't have control over new environments, which is precisely the case with the Boost releases, where we don't check if each library is testing that new environment before changing it. Release managers just assume a library workflow (especially just the documentation generator) won't break the whole thing. |
No description provided.