Skip to content

[mdspan.layout.right.obs] Add missing constexpr to required_span_size. #7872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

1uc
Copy link

@1uc 1uc commented May 13, 2025

The missing constexpr looks like a typo, because it's present in the overview; and every other method is constexpr.

@jwakely
Copy link
Member

jwakely commented May 13, 2025

The constexpr was missing in the incoming paper, P0009R18, but I agree that it looks like an editorial mistake.

@jensmaurer
Copy link
Member

@mhoemmen , any comments here?

@mhoemmen
Copy link
Contributor

@jensmaurer Thanks for the heads-up! Thanks @1uc for pointing this out!

I agree that this must have been an editorial mistake. It was certainly the intention for required_span_size() to be marked constexpr in layout_right::mapping. It's already marked constexpr in the other two C++23 layout mappings (layout_left::mapping and layout_stride::mapping).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants