Skip to content

[sequence.reqmts] Fix application of P2846R6 for assign_range #7869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #7865.

@frederick-vs-ja frederick-vs-ja changed the title [sequence.reqmts] Fix application of P2846R6 for append_range [sequence.reqmts] Fix application of P2846R6 for assign_range May 12, 2025
@tkoeppe
Copy link
Contributor

tkoeppe commented May 12, 2025

Thanks!

@tkoeppe tkoeppe requested a review from jwakely May 12, 2025 13:12
@tkoeppe
Copy link
Contributor

tkoeppe commented May 12, 2025

Looks like this is causing some overful box?

@jensmaurer
Copy link
Member

Overfull \hbox (7.71753pt too wide) in paragraph at lines 19239--19244

@frederick-vs-ja
Copy link
Contributor Author

frederick-vs-ja commented May 12, 2025

Oh, the overfull seems existing in previous PR:

https://github.com/cplusplus/draft/actions/runs/14899864186/job/41849372688

Seems to be caused by #7867.

@jensmaurer
Copy link
Member

Fixed with 4b1283b

@jensmaurer jensmaurer closed this May 12, 2025
@frederick-vs-ja frederick-vs-ja deleted the single-reallocation branch May 13, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sequence.reqmts] P2846 incorrectly applied for assign_range
4 participants