Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Motions 2023 11 lwg 1] P3040R0 C++ Standard Library Issues #6685

Merged
merged 22 commits into from
Dec 17, 2023
Merged

[Motions 2023 11 lwg 1] P3040R0 C++ Standard Library Issues #6685

merged 22 commits into from
Dec 17, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 14, 2023 •
edited by jensmaurer
Loading

Fixes #6659.

Fixes cplusplus/papers#1714
Also fixes #6353

Notes:

  • LWG3965 skipped; I don't know how to apply this change.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 14, 2023

Thanks a lot! Is this PR ready then? It's still in "draft" status. Don't worry about the missing issue.

@burblebee burblebee force-pushed the motions-2023-11-lwg-1 branch from 7f8629f to 6b60ba2 Compare November 14, 2023 10:46
@burblebee burblebee marked this pull request as ready for review November 14, 2023 10:53
@jensmaurer jensmaurer added this to the post-2023-11 milestone Nov 15, 2023
JohelEGP
JohelEGP suggested changes Nov 16, 2023
View reviewed changes
source/strings.tex Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Nov 17, 2023
View reviewed changes
source/strings.tex Outdated Show resolved Hide resolved
@burblebee burblebee requested a review from JohelEGP November 17, 2023 02:52
@burblebee
Copy link
Contributor Author

@tkoeppe, your choice to either apply or skip that last commit.

@burblebee burblebee requested a review from jwakely November 17, 2023 18:23
JohelEGP
JohelEGP suggested changes Nov 17, 2023
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
@burblebee burblebee requested a review from JohelEGP November 17, 2023 19:14
@tkoeppe tkoeppe force-pushed the motions-2023-11-lwg-1 branch 2 times, most recently from 0913e64 to 4690ffb Compare December 17, 2023 02:20
@burblebee @tkoeppe
LWG2392 "character type" is used but not defined
486ed41
@burblebee @tkoeppe
LWG3203 span element access invalidation
c9856cc
@burblebee @tkoeppe
LWG3305 any_cast<void>
b103946
@burblebee @tkoeppe
LWG3431 <=> for containers should require three_way_comparable<T> ins…
2b36a7e 
…tead of <=>
@burblebee @tkoeppe
LWG3749 common_iterator should handle integer-class difference types
4ed5a13
@burblebee @tkoeppe
LWG3892 Incorrect formatting of nested ranges and tuples
bc86100
@burblebee @tkoeppe
LWG3897 inout_ptr will not update raw pointer to 0
765a692
@burblebee @tkoeppe
LWG3946 The definition of const_iterator_t should be reworked
16c66ad
@burblebee @tkoeppe
LWG3809 Is std::subtract_with_carry_engine<uint16_t> supposed to work?
3cee8a7
@burblebee @tkoeppe
LWG3947 Unexpected constraints on adjacent_transform_view::base()
a4a9db9
@burblebee @tkoeppe
LWG3948 possibly-const-range and as-const-pointer should be noexcept
a457442
@burblebee @tkoeppe
LWG3949 std::atomic<bool>'s trivial destructor dropped in C++17 spec …
997bbeb 
…wording
@burblebee @tkoeppe
LWG3951 §[expected.object.swap]: Using value() instead of has_value()
e879f02
@burblebee @tkoeppe
LWG3953 iter_move for common_iterator and counted_iterator should ret…
4c05272 
…urn decltype(auto)
@burblebee @tkoeppe
LWG3957 §[container.alloc.reqmts] The value category of v should be c…
f83e137 
…laimed
@tkoeppe tkoeppe force-pushed the motions-2023-11-lwg-1 branch from 4690ffb to 4c58d5f Compare December 17, 2023 02:37
@tkoeppe tkoeppe force-pushed the motions-2023-11-lwg-1 branch from 4c58d5f to a3fdcf1 Compare December 17, 2023 02:54
@tkoeppe tkoeppe merged commit 7805874 into main Dec 17, 2023
4 checks passed
@jensmaurer jensmaurer deleted the motions-2023-11-lwg-1 branch March 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@JohelEGP JohelEGP JohelEGP approved these changes

@jwakely jwakely Awaiting requested review from jwakely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-11
5 participants
@burblebee @tkoeppe @jwakely @JohelEGP @jensmaurer