-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[conv.integral, conv.double] Fix promotion conversions #3963
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem to be three independent changes. Please make that three commits.
@jensmaurer Should be good now. |
2953ccd
to
1782eb7
Compare
This appears to be a normative change: it affects which conversions are permitted in converted constant expressions. It might be a good change, and it's certainly clearer to have each conversion have only one kind, but this should probably be handled by a core issue. |
@sdkrystian Could you please rebase? |
@tkoeppe Yup, will do it Monday |
@tkoeppe Rebased |
Thanks! We'll have to look at it in Core, but we wanted a clean diff. |
bool
to [conv.bool], we can just exclude them from the set of integral conversions (no normative effects as it delegates).float
todouble
); we need not say "conversions".