Feature/caws mutable data stream batch domain #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanchen233
requested changes
Jun 20, 2024
src/main/kotlin/dk/cachet/carp/webservices/data/domain/CawsMutableDataStreamBatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dk/cachet/carp/webservices/data/domain/CawsMutableDataStreamBatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dk/cachet/carp/webservices/data/domain/CawsMutableDataStreamBatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dk/cachet/carp/webservices/data/domain/CawsMutableDataStreamBatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dk/cachet/carp/webservices/data/domain/CawsMutableDataStreamBatch.kt
Outdated
Show resolved
Hide resolved
|
All the changes were taken into account + additional functionality of functioning of appendToDataStream which I haven't considered. @yuanchen233 |
yuanchen233
approved these changes
Jun 21, 2024
|
This is a temperate solution to get rid of the sequence id check, due to the lack of access to last sequence from the server side. New functionalities should not build on top of this solution, referring to core implementation instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buffer issue to allow .json to openDataStream, appendToDataStream, closeDataStream, getDataStream