Skip to content

fix: stop Enter propagation when transitioning to Input steps in appl… #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpaczek merged 1 commit into from
Apr 6, 2026
Merged

fix: stop Enter propagation when transitioning to Input steps in appl… #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/tui/apply/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ export async function runApplyTUI(
// Input steps (name, personality_custom) are handled by InputRenderableEvents.ENTER
// on the widget itself (set up in addInput callbacks). This handler covers
// confirmations (Y/N), Select steps, and navigation-only steps.
function handleKeys(key: { name?: string; ctrl?: boolean }): void {
function handleKeys(key: { name?: string; ctrl?: boolean; stopPropagation?(): void }): void {
if (key.ctrl) return; // Ctrl+C handled separately

switch (currentStep) {
Expand All @@ -575,7 +575,13 @@ export async function runApplyTUI(
break;

case 'searching':
if (key.name === 'return' && saltResult) showStep('name');
if (key.name === 'return' && saltResult) {
showStep('name');
// Stop propagation so the Enter that triggered this transition is not
// delivered to the newly-focused Input widget (which would instantly
// submit it with an empty value, skipping the name step entirely).
key.stopPropagation?.();
}
break;

// 'name' and 'personality_custom' — Enter handled by Input widget callbacks
Expand All @@ -598,6 +604,9 @@ export async function runApplyTUI(
nextAfterPersonality();
} else {
showStep('personality_custom');
// Same as above: stop propagation so the Enter that selected
// "Write custom" is not delivered to the newly-focused Input.
key.stopPropagation?.();
}
}
break;
Expand Down
Loading