fix: reload config fresh to prevent stale-snapshot profile loss

[Co-Messi]

Problem

When generating multiple buddies, profiles created earlier could go missing from the saved-buddies gallery.

Two stale-snapshot writes were clobbering data that had already been written by a fresh saveProfile() call:

runBuddies — isDefault case
saveProfile(outgoing) performs a fresh load → write to snapshot the outgoing buddy's current name/personality.
Then savePetConfigV2(config) overwrites the file with the stale config captured at the very top of runBuddies(). Any profile data written by the intervening saveProfile call is silently lost.

applyDesiredTraitsSequential — final identity update
The code read configV2.profiles[result.salt] from a snapshot loaded before the patch step. If loadPetConfigV2() returned null at that point (e.g. a transient read error) the fallback used profiles: {}, which then got saved, wiping all existing profiles. Even without the null case, the snapshot could be stale relative to what saveProfile() had just written.

Fix

Both sites now reload the config fresh immediately before writing:

// buddies.ts — isDefault case
const freshConfig = loadPetConfigV2();
if (freshConfig) {
  freshConfig.previousSalt = freshConfig.salt;
  freshConfig.activeProfile = null;
  freshConfig.salt = newSalt;
  ...
  savePetConfigV2(freshConfig);
}

// interactive.ts — final profile identity update
const freshConfig = loadPetConfigV2();
const saved = freshConfig?.profiles[result.salt];
if (saved) { ... saveProfile(saved, { activate: true }); }

Test plan

• Create two buddies back-to-back — both appear in any-buddy buddies
• Switch a buddy, switch back to Original — verify both buddy profiles still present
• pnpm test — all 203 tests pass

[cpaczek]

@Co-Messi thank you for PR merged