Skip to content

Conversation

cuichen01
Copy link
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 86.07306% with 61 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...bservability/domain/trace/service/trace_service.go 77.96% 10 Missing and 3 partials ⚠️
...dler/coze/loop/apis/observability_trace_service.go 0.00% 11 Missing ⚠️
backend/modules/observability/application/trace.go 89.53% 6 Missing and 3 partials ⚠️
...ace/service/trace/span_processor/clip_processor.go 89.88% 6 Missing and 3 partials ⚠️
...ckend/modules/observability/application/openapi.go 94.49% 4 Missing and 2 partials ⚠️
...kend/modules/observability/infra/repo/ck/common.go 61.53% 3 Missing and 2 partials ⚠️
.../observability/application/convertor/trace/span.go 0.00% 2 Missing and 1 partial ⚠️
...s/observability/infra/collector/event_collector.go 0.00% 3 Missing ⚠️
...er/coze/loop/apis/observability_open_apiservice.go 0.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   64.25%   64.34%   +0.08%     
==========================================
  Files         507      510       +3     
  Lines       56715    57115     +400     
==========================================
+ Hits        36445    36748     +303     
- Misses      17750    17823      +73     
- Partials     2520     2544      +24     
Flag Coverage Δ
unittests 64.34% <86.07%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ervability/domain/trace/entity/loop_span/filter.go 70.21% <100.00%> (ø)
...bservability/domain/trace/entity/loop_span/span.go 76.67% <100.00%> (+1.34%) ⬆️
...rvability/domain/trace/entity/otel/otel_pb2json.go 95.15% <100.00%> (ø)
...ackend/modules/observability/infra/config/trace.go 94.78% <100.00%> (+0.28%) ⬆️
...ckend/modules/observability/infra/repo/ck/spans.go 50.32% <100.00%> (+6.55%) ⬆️
backend/modules/observability/infra/repo/trace.go 61.12% <100.00%> (+0.46%) ⬆️
...er/coze/loop/apis/observability_open_apiservice.go 0.00% <0.00%> (ø)
.../observability/application/convertor/trace/span.go 52.90% <0.00%> (+13.85%) ⬆️
...s/observability/infra/collector/event_collector.go 0.00% <0.00%> (ø)
...kend/modules/observability/infra/repo/ck/common.go 61.53% <61.53%> (ø)
... and 5 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6acd40...a56fb3e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cuichen01 and others added 19 commits October 13, 2025 21:34
(LogID: 202510141631250100910941971269738)

Co-Authored-By: Coda <[email protected]>
(LogID: 202510141631250100910941971269738)

Co-Authored-By: Coda <[email protected]>
(LogID: 20251014175401010091094197096B65A)

Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda

Co-Authored-By: Coda <[email protected]>
(LogID: 2025101419340301009109419719038F1)

Co-Authored-By: Coda <[email protected]>
   🤖 Generated with Coda
(LogID: 202510142136120100910941975788B9C)

Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda

Co-Authored-By: Coda <[email protected]>
(LogID: 20251015121552010091094197109BD6B)

Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda

Co-Authored-By: Coda <[email protected]>
(LogID: 20251015121552010091094197109BD6B)

Co-Authored-By: Coda <[email protected]>
(LogID: 2025101517003901009109419764992EC)

Co-Authored-By: Coda <[email protected]>
(LogID: 2025101517003901009109419764992EC)

Co-Authored-By: Coda <[email protected]>
🤖 Generated with Coda

Co-Authored-By: Coda <[email protected]>
(LogID: 2025101517003901009109419764992EC)

Co-Authored-By: Coda <[email protected]>
(LogID: 2025101517003901009109419764992EC)

Co-Authored-By: Coda <[email protected]>
platformType := loop_span.PlatformType(req.GetPlatformType())
if req.PlatformType == nil {
platformType = loop_span.PlatformCozeLoop
platformType = loop_span.PlatformDefault
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default的配置和cozeloop都是一致的了是吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

预期default是目前所有配置的最小公共部分,上线前我再ckeck下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants