-
Notifications
You must be signed in to change notification settings - Fork 15
Rename beta_job to job, but keep beta_job as alias #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d8855a7 to
b563784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the beta_job block to job while maintaining backwards compatibility by keeping beta_job as a supported alias. The change promotes the job functionality from beta status to stable.
- Updated the primary block name from
beta_jobtojobin configuration structures - Implemented automatic renaming of legacy
beta_jobblocks tojobduring configuration loading - Added test coverage for the legacy
beta_jobalias to ensure backwards compatibility
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| config/definitions.go | Updated struct tag from beta_job to job for the Job field |
| config/configload/load.go | Added normalizeLegacyBlocks function to automatically rename beta_job blocks to job during parsing |
| config/configload/helper.go | Added renameDefinitionBlocks helper function and call to support legacy block renaming |
| config/configload/tests.go | Added normalization calls to test loading functions |
| config/runtime/server.go | Updated error message to reference job instead of beta_job |
| server/testdata/definitions/01_job.hcl | Updated test file to use job block name |
| server/testdata/definitions/02_job.hcl | Updated test file to use job block name |
| server/testdata/definitions/03_job.hcl | Updated test file to use job block name |
| server/testdata/definitions/04_job.hcl | Updated test file to use job block name |
| server/testdata/definitions/05_job.hcl | Updated test file to use job block name |
| server/testdata/definitions/06_beta_job.hcl | Added new test file to verify beta_job alias still works |
| server/http_definitions_test.go | Added test case for beta_job without label to verify alias support |
| docs/website/content/2.configuration/4.block/job.md | Updated documentation to reflect job as primary name with note about beta_job alias |
| docs/website/content/2.configuration/4.block/definitions.md | Updated block reference and added note about legacy beta_job support |
| docs/website/content/3.observation/logging.md | Updated field description to reference job block with beta_job alias note |
| CHANGELOG.md | Added entry documenting the change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b563784 to
b3f942a
Compare
CHANGELOG.md
Outdated
| Unreleased changes are available as `coupergateway/couper:edge` container. | ||
|
|
||
| * **Changed** | ||
| * [`job`](https://docs.couper.io/configuration/block/job) block replaces the legacy `beta_job` name while keeping the alias for backwards compatibility. ([#898](https://github.com/coupergateway/couper/pull/898)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets sell it as stable promotion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the change correct like that?
b3f942a to
acd5fbb
Compare
This renames
beta_jobtojob, but keepsbeta_jobas alias forjob.Reviewer checklist