Skip to content

Conversation

@mobilutz
Copy link

This renames beta_job to job, but keeps beta_job as alias for job.


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@mobilutz mobilutz force-pushed the deprecate-beta-jobs branch 3 times, most recently from d8855a7 to b563784 Compare November 13, 2025 20:51
@mobilutz mobilutz marked this pull request as ready for review November 13, 2025 20:56
Copilot AI review requested due to automatic review settings November 13, 2025 20:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the beta_job block to job while maintaining backwards compatibility by keeping beta_job as a supported alias. The change promotes the job functionality from beta status to stable.

  • Updated the primary block name from beta_job to job in configuration structures
  • Implemented automatic renaming of legacy beta_job blocks to job during configuration loading
  • Added test coverage for the legacy beta_job alias to ensure backwards compatibility

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
config/definitions.go Updated struct tag from beta_job to job for the Job field
config/configload/load.go Added normalizeLegacyBlocks function to automatically rename beta_job blocks to job during parsing
config/configload/helper.go Added renameDefinitionBlocks helper function and call to support legacy block renaming
config/configload/tests.go Added normalization calls to test loading functions
config/runtime/server.go Updated error message to reference job instead of beta_job
server/testdata/definitions/01_job.hcl Updated test file to use job block name
server/testdata/definitions/02_job.hcl Updated test file to use job block name
server/testdata/definitions/03_job.hcl Updated test file to use job block name
server/testdata/definitions/04_job.hcl Updated test file to use job block name
server/testdata/definitions/05_job.hcl Updated test file to use job block name
server/testdata/definitions/06_beta_job.hcl Added new test file to verify beta_job alias still works
server/http_definitions_test.go Added test case for beta_job without label to verify alias support
docs/website/content/2.configuration/4.block/job.md Updated documentation to reflect job as primary name with note about beta_job alias
docs/website/content/2.configuration/4.block/definitions.md Updated block reference and added note about legacy beta_job support
docs/website/content/3.observation/logging.md Updated field description to reference job block with beta_job alias note
CHANGELOG.md Added entry documenting the change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mobilutz mobilutz force-pushed the deprecate-beta-jobs branch from b563784 to b3f942a Compare November 14, 2025 08:14
CHANGELOG.md Outdated
Unreleased changes are available as `coupergateway/couper:edge` container.

* **Changed**
* [`job`](https://docs.couper.io/configuration/block/job) block replaces the legacy `beta_job` name while keeping the alias for backwards compatibility. ([#898](https://github.com/coupergateway/couper/pull/898))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets sell it as stable promotion :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change correct like that?

@mobilutz mobilutz force-pushed the deprecate-beta-jobs branch from b3f942a to acd5fbb Compare November 26, 2025 20:31
@mobilutz mobilutz requested a review from malud November 26, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants