This repository was archived by the owner on Dec 13, 2019. It is now read-only.
[Wallet-UI] Various small fixes #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelalejandro
approved these changes
Jul 22, 2019
cf19drofxots
pushed a commit
that referenced
this pull request
Jul 24, 2019
* Update dependency ts-mockito to v2.3.2 * Fix erorrgp * Bulk deps update (#1947) * Update dependency @types/react to v16.8.23 * Update dependency truffle-hdwallet-provider to v1.0.13 * Pin dependencies * chore(deps): update dependency @firebase/util to v0.2.21 * chore(deps): update dependency @types/enzyme to v3.10.2 * chore(deps): update dependency @types/react-redux to v7.1.1 * chore(deps): update dependency copyfiles to v2.1.1 * chore(deps): update dependency eth-gas-reporter to v0.2.4 * chore(deps): update dependency ganache-cli to v6.4.5 * Update dependency rollup to v1.16.7 * chore(deps): update dependency ganache-core to v2.5.7 * chore(deps): update dependency solidity-coverage to v0.6.2 * chore(deps): update dependency rollup-plugin-typescript2 to v0.22.0 * Update dependency truffle-hdwallet-provider to v1.0.14 * chore(deps): update dependency truffle to v5.0.27 * chore(deps): update dependency tslint to v5.18.0 * chore(deps): update postgres docker tag to v11.4 * fix(deps): update dependency @types/node to v12.6.2 * fix(deps): update dependency truffle-contract to v4.0.24 * chore(deps): update dependency ethers to v4.0.33 (#1863) * Update dependency knex to ^0.19.0 (#1866) * Update dependency redux to v4.0.4 (#1867) * chore(deps): update dependency typescript to v3.5.3 (#1874) * chore(deps): update dependency prettier to v1.18.2 (#1884) * chore(deps): update dependency sqlite3 to v4.0.9 (#1886) * chore(deps): update dependency ts-node to v8.3.0 (#1888) * fix(deps): update dependency p-queue to v6 (#1893) * update after merge * Revert pqueue * Pin dependency jest-fetch-mock to 2.1.2 * Update dependency @firebase/util to v0.2.22 * Update dependency lerna to v3.16.1 * Remove yarn locks * Rename signingKeys to participants (#1960) * Fix (#1961) * [Wallet-UI] Various small fixes (#1968) * fix deposit not showing current balance * refactor formInput * remove comment * show errors that had no code, fix behaviour for CTA button * fix some error msgs, avoid unhandled throw on post * remove console log * remove warning * add log for deposit errors, error recovery * improve test selectors * Remove unused parameter (#1966) * Use BigNumberish not BigNumber | number (#1963) * Use name tokenAddress where possible (#1964) * [wallet-ui] Fixes `depositConfirmedEvent` on onboarding flow (#1919) * fixed depositConfirmedEvent Co-Authored-By: Santiago Pérsico <[email protected]> * fix wallet-ui getBalance polling * add test logs * working on secure-deposit tests (still failing) * Remove logs * fixed event handler routing, all tests should be passing * fixed linting issues * [contracts] Fix contracts build dir (#1974) * Redeployed kovan contracts * Add rinkeby deployments * Add ropsten deployments * Update package versions * [node] Remove nofiyCounterparty param (#1969) * Remove nofiyCounterparty param * Update operation * Update README * Update test * Patch event handler * Get deposit test passing * lint * Remove unused file (#1972) * Recursively serialize state object in fromJson (#1967) * Recursively serialize state object in fromJson * Remove unused import * Remove unused method & file (#1970) * Remove unused method & file * Update controller.ts * [node] Casting quickfix in app install (#1957) * tag the rpc method * remove semicolon from tag doh * trashy casting xoxo gossip girl * remove logging * Serialize properly at protocol handler level * Bump node version to 0.2.24 * Add back bignumberify that's on master * Make some functions functional (#1973) * Make some functions functional * More deascriptive accumulator names * Type dispatch to return JsonRpcResponse (#1965) * Type dispatch to return JsonRpcResponse * Remove unused import * Change test expected value * Fix some code smells (#1971) * Better testing of CoinTransferInterpreter (#1977) * Remove duplicate code in test file (#1976)
snario
pushed a commit
that referenced
this pull request
Jul 28, 2019
* Update dependency ts-mockito to v2.3.2 * Fix erorrgp * Bulk deps update (#1947) * Update dependency @types/react to v16.8.23 * Update dependency truffle-hdwallet-provider to v1.0.13 * Pin dependencies * chore(deps): update dependency @firebase/util to v0.2.21 * chore(deps): update dependency @types/enzyme to v3.10.2 * chore(deps): update dependency @types/react-redux to v7.1.1 * chore(deps): update dependency copyfiles to v2.1.1 * chore(deps): update dependency eth-gas-reporter to v0.2.4 * chore(deps): update dependency ganache-cli to v6.4.5 * Update dependency rollup to v1.16.7 * chore(deps): update dependency ganache-core to v2.5.7 * chore(deps): update dependency solidity-coverage to v0.6.2 * chore(deps): update dependency rollup-plugin-typescript2 to v0.22.0 * Update dependency truffle-hdwallet-provider to v1.0.14 * chore(deps): update dependency truffle to v5.0.27 * chore(deps): update dependency tslint to v5.18.0 * chore(deps): update postgres docker tag to v11.4 * fix(deps): update dependency @types/node to v12.6.2 * fix(deps): update dependency truffle-contract to v4.0.24 * chore(deps): update dependency ethers to v4.0.33 (#1863) * Update dependency knex to ^0.19.0 (#1866) * Update dependency redux to v4.0.4 (#1867) * chore(deps): update dependency typescript to v3.5.3 (#1874) * chore(deps): update dependency prettier to v1.18.2 (#1884) * chore(deps): update dependency sqlite3 to v4.0.9 (#1886) * chore(deps): update dependency ts-node to v8.3.0 (#1888) * fix(deps): update dependency p-queue to v6 (#1893) * update after merge * Revert pqueue * Pin dependency jest-fetch-mock to 2.1.2 * Update dependency @firebase/util to v0.2.22 * Update dependency lerna to v3.16.1 * Remove yarn locks * Rename signingKeys to participants (#1960) * Fix (#1961) * [Wallet-UI] Various small fixes (#1968) * fix deposit not showing current balance * refactor formInput * remove comment * show errors that had no code, fix behaviour for CTA button * fix some error msgs, avoid unhandled throw on post * remove console log * remove warning * add log for deposit errors, error recovery * improve test selectors * Remove unused parameter (#1966) * Use BigNumberish not BigNumber | number (#1963) * Use name tokenAddress where possible (#1964) * [wallet-ui] Fixes `depositConfirmedEvent` on onboarding flow (#1919) * fixed depositConfirmedEvent Co-Authored-By: Santiago Pérsico <[email protected]> * fix wallet-ui getBalance polling * add test logs * working on secure-deposit tests (still failing) * Remove logs * fixed event handler routing, all tests should be passing * fixed linting issues * [contracts] Fix contracts build dir (#1974) * Redeployed kovan contracts * Add rinkeby deployments * Add ropsten deployments * Update package versions * [node] Remove nofiyCounterparty param (#1969) * Remove nofiyCounterparty param * Update operation * Update README * Update test * Patch event handler * Get deposit test passing * lint * Remove unused file (#1972) * Recursively serialize state object in fromJson (#1967) * Recursively serialize state object in fromJson * Remove unused import * Remove unused method & file (#1970) * Remove unused method & file * Update controller.ts * [node] Casting quickfix in app install (#1957) * tag the rpc method * remove semicolon from tag doh * trashy casting xoxo gossip girl * remove logging * Serialize properly at protocol handler level * Bump node version to 0.2.24 * Add back bignumberify that's on master * Make some functions functional (#1973) * Make some functions functional * More deascriptive accumulator names * Type dispatch to return JsonRpcResponse (#1965) * Type dispatch to return JsonRpcResponse * Remove unused import * Change test expected value * Fix some code smells (#1971) * Better testing of CoinTransferInterpreter (#1977) * Remove duplicate code in test file (#1976)
snario
pushed a commit
that referenced
this pull request
Jul 28, 2019
* Update dependency ts-mockito to v2.3.2 * Fix erorrgp * Bulk deps update (#1947) * Update dependency @types/react to v16.8.23 * Update dependency truffle-hdwallet-provider to v1.0.13 * Pin dependencies * chore(deps): update dependency @firebase/util to v0.2.21 * chore(deps): update dependency @types/enzyme to v3.10.2 * chore(deps): update dependency @types/react-redux to v7.1.1 * chore(deps): update dependency copyfiles to v2.1.1 * chore(deps): update dependency eth-gas-reporter to v0.2.4 * chore(deps): update dependency ganache-cli to v6.4.5 * Update dependency rollup to v1.16.7 * chore(deps): update dependency ganache-core to v2.5.7 * chore(deps): update dependency solidity-coverage to v0.6.2 * chore(deps): update dependency rollup-plugin-typescript2 to v0.22.0 * Update dependency truffle-hdwallet-provider to v1.0.14 * chore(deps): update dependency truffle to v5.0.27 * chore(deps): update dependency tslint to v5.18.0 * chore(deps): update postgres docker tag to v11.4 * fix(deps): update dependency @types/node to v12.6.2 * fix(deps): update dependency truffle-contract to v4.0.24 * chore(deps): update dependency ethers to v4.0.33 (#1863) * Update dependency knex to ^0.19.0 (#1866) * Update dependency redux to v4.0.4 (#1867) * chore(deps): update dependency typescript to v3.5.3 (#1874) * chore(deps): update dependency prettier to v1.18.2 (#1884) * chore(deps): update dependency sqlite3 to v4.0.9 (#1886) * chore(deps): update dependency ts-node to v8.3.0 (#1888) * fix(deps): update dependency p-queue to v6 (#1893) * update after merge * Revert pqueue * Pin dependency jest-fetch-mock to 2.1.2 * Update dependency @firebase/util to v0.2.22 * Update dependency lerna to v3.16.1 * Remove yarn locks * Rename signingKeys to participants (#1960) * Fix (#1961) * [Wallet-UI] Various small fixes (#1968) * fix deposit not showing current balance * refactor formInput * remove comment * show errors that had no code, fix behaviour for CTA button * fix some error msgs, avoid unhandled throw on post * remove console log * remove warning * add log for deposit errors, error recovery * improve test selectors * Remove unused parameter (#1966) * Use BigNumberish not BigNumber | number (#1963) * Use name tokenAddress where possible (#1964) * [wallet-ui] Fixes `depositConfirmedEvent` on onboarding flow (#1919) * fixed depositConfirmedEvent Co-Authored-By: Santiago Pérsico <[email protected]> * fix wallet-ui getBalance polling * add test logs * working on secure-deposit tests (still failing) * Remove logs * fixed event handler routing, all tests should be passing * fixed linting issues * [contracts] Fix contracts build dir (#1974) * Redeployed kovan contracts * Add rinkeby deployments * Add ropsten deployments * Update package versions * [node] Remove nofiyCounterparty param (#1969) * Remove nofiyCounterparty param * Update operation * Update README * Update test * Patch event handler * Get deposit test passing * lint * Remove unused file (#1972) * Recursively serialize state object in fromJson (#1967) * Recursively serialize state object in fromJson * Remove unused import * Remove unused method & file (#1970) * Remove unused method & file * Update controller.ts * [node] Casting quickfix in app install (#1957) * tag the rpc method * remove semicolon from tag doh * trashy casting xoxo gossip girl * remove logging * Serialize properly at protocol handler level * Bump node version to 0.2.24 * Add back bignumberify that's on master * Make some functions functional (#1973) * Make some functions functional * More deascriptive accumulator names * Type dispatch to return JsonRpcResponse (#1965) * Type dispatch to return JsonRpcResponse * Remove unused import * Change test expected value * Fix some code smells (#1971) * Better testing of CoinTransferInterpreter (#1977) * Remove duplicate code in test file (#1976)
snario
added a commit
that referenced
this pull request
Jul 28, 2019
* Update dependency @types/react to v16.8.23 * Pin dependencies * chore(deps): update dependency @firebase/util to v0.2.21 * chore(deps): update dependency @types/enzyme to v3.10.2 * chore(deps): update dependency @types/react-redux to v7.1.1 * chore(deps): update dependency copyfiles to v2.1.1 * chore(deps): update dependency eth-gas-reporter to v0.2.4 * chore(deps): update dependency ganache-cli to v6.4.5 * chore(deps): update dependency ganache-core to v2.5.7 * chore(deps): update dependency solidity-coverage to v0.6.2 * chore(deps): update dependency rollup-plugin-typescript2 to v0.22.0 * chore(deps): update dependency truffle to v5.0.27 * fix(deps): update dependency @types/node to v12.6.2 * fix(deps): update dependency truffle-contract to v4.0.24 * chore(deps): update dependency ethers to v4.0.33 (#1863) * Update dependency redux to v4.0.4 (#1867) * chore(deps): update dependency typescript to v3.5.3 (#1874) * chore(deps): update dependency prettier to v1.18.2 (#1884) * chore(deps): update dependency ts-node to v8.3.0 (#1888) * fix(deps): update dependency p-queue to v6 (#1893) * update after merge * Revert pqueue * Pin dependency jest-fetch-mock to 2.1.2 * Update dependency @firebase/util to v0.2.22 * Update dependency lerna to v3.16.1 * Remove yarn locks * Update dependency ts-mockito to v2.3.2 (#1943) * Update dependency ts-mockito to v2.3.2 * Fix erorrgp * Bulk deps update (#1947) * Update dependency @types/react to v16.8.23 * Update dependency truffle-hdwallet-provider to v1.0.13 * Pin dependencies * chore(deps): update dependency @firebase/util to v0.2.21 * chore(deps): update dependency @types/enzyme to v3.10.2 * chore(deps): update dependency @types/react-redux to v7.1.1 * chore(deps): update dependency copyfiles to v2.1.1 * chore(deps): update dependency eth-gas-reporter to v0.2.4 * chore(deps): update dependency ganache-cli to v6.4.5 * Update dependency rollup to v1.16.7 * chore(deps): update dependency ganache-core to v2.5.7 * chore(deps): update dependency solidity-coverage to v0.6.2 * chore(deps): update dependency rollup-plugin-typescript2 to v0.22.0 * Update dependency truffle-hdwallet-provider to v1.0.14 * chore(deps): update dependency truffle to v5.0.27 * chore(deps): update dependency tslint to v5.18.0 * chore(deps): update postgres docker tag to v11.4 * fix(deps): update dependency @types/node to v12.6.2 * fix(deps): update dependency truffle-contract to v4.0.24 * chore(deps): update dependency ethers to v4.0.33 (#1863) * Update dependency knex to ^0.19.0 (#1866) * Update dependency redux to v4.0.4 (#1867) * chore(deps): update dependency typescript to v3.5.3 (#1874) * chore(deps): update dependency prettier to v1.18.2 (#1884) * chore(deps): update dependency sqlite3 to v4.0.9 (#1886) * chore(deps): update dependency ts-node to v8.3.0 (#1888) * fix(deps): update dependency p-queue to v6 (#1893) * update after merge * Revert pqueue * Pin dependency jest-fetch-mock to 2.1.2 * Update dependency @firebase/util to v0.2.22 * Update dependency lerna to v3.16.1 * Remove yarn locks * Rename signingKeys to participants (#1960) * Fix (#1961) * [Wallet-UI] Various small fixes (#1968) * fix deposit not showing current balance * refactor formInput * remove comment * show errors that had no code, fix behaviour for CTA button * fix some error msgs, avoid unhandled throw on post * remove console log * remove warning * add log for deposit errors, error recovery * improve test selectors * Remove unused parameter (#1966) * Use BigNumberish not BigNumber | number (#1963) * Use name tokenAddress where possible (#1964) * [wallet-ui] Fixes `depositConfirmedEvent` on onboarding flow (#1919) * fixed depositConfirmedEvent Co-Authored-By: Santiago Pérsico <[email protected]> * fix wallet-ui getBalance polling * add test logs * working on secure-deposit tests (still failing) * Remove logs * fixed event handler routing, all tests should be passing * fixed linting issues * [contracts] Fix contracts build dir (#1974) * Redeployed kovan contracts * Add rinkeby deployments * Add ropsten deployments * Update package versions * [node] Remove nofiyCounterparty param (#1969) * Remove nofiyCounterparty param * Update operation * Update README * Update test * Patch event handler * Get deposit test passing * lint * Remove unused file (#1972) * Recursively serialize state object in fromJson (#1967) * Recursively serialize state object in fromJson * Remove unused import * Remove unused method & file (#1970) * Remove unused method & file * Update controller.ts * [node] Casting quickfix in app install (#1957) * tag the rpc method * remove semicolon from tag doh * trashy casting xoxo gossip girl * remove logging * Serialize properly at protocol handler level * Bump node version to 0.2.24 * Add back bignumberify that's on master * Make some functions functional (#1973) * Make some functions functional * More deascriptive accumulator names * Type dispatch to return JsonRpcResponse (#1965) * Type dispatch to return JsonRpcResponse * Remove unused import * Change test expected value * Fix some code smells (#1971) * Better testing of CoinTransferInterpreter (#1977) * Remove duplicate code in test file (#1976) * Update dependency ethereum-waffle to v2.0.15 * Update dependency @firebase/util to v0.2.23 * Update dependency @types/react-dom to v16.8.5 * Update dependency lerna to v3.16.4 * Update dependency pg to v7.12.0 * Update dependency puppeteer to v1.19.0 * Update dependency truffle to v5.0.29 * Update dependency truffle-contract to v4.0.26 * Update dependency ts-mockito to v2.4.2 * Update dependency rollup-plugin-typescript2 to v0.22.1 * Update dependency truffle-hdwallet-provider to v1.0.15 * Update dependency eth-gas-reporter to v0.2.7 * Update dependency typedoc to v0.15.0 * Update dependency eth-gas-reporter to v0.2.8 * Update pckgs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several errors found in the Wallet-UI by @joelalejandro, and another one that could crash the app when the account creation function call failed.
It also leaves the deposit screen ready to handle errors for when we manage to make deposits work.
Related issues