Skip to content
This repository was archived by the owner on Dec 13, 2019. It is now read-only.

[wallet-ui] Test-Suites and bug fixing #1858

Merged
merged 42 commits into from
Jul 17, 2019
Merged

[wallet-ui] Test-Suites and bug fixing #1858

merged 42 commits into from
Jul 17, 2019

Conversation

spersico
Copy link
Collaborator

@spersico spersico commented Jul 13, 2019 •
edited by joelalejandro
Loading

Description

This PR will tackle a good amount the testing part of #1852, and it will include fixes here and there as we find them. 😄

As @joelalejandro explains:

Learning from previous mistakes, we're building tests for every component and looking into integration flows. Now that we're working with React, we have better supported tools to do this. With this in mind, we can resume the PoC we did a couple of months ago with the WebDriver that auto-configures the Metamask extension, allowing us to test a dapp interacting with our Wallet.

The test suite will stay in the issue, as it has more visibility, and I don't think it's wise to duplicate it.

Related issues

#1852

spersico and others added 17 commits July 12, 2019 15:30
@spersico
initial approach to integration testing
098de9f
@spersico
fix isolatedModules crash
0dae56e
@spersico
fix some account registration details
a7f1044
@spersico
implement in testing element selection logic
64f3d60
@spersico
add first meaningfull interaction test
396637c
@spersico
clean payload from accountRegistration function call
0231bc4
@joelalejandro
redefined EthereumGlobal to reuse it in mocks
c5f0f84
@joelalejandro
implemented first version of EthereumMock
ad6547c
@spersico
add "addUser" integration test
6d030af
@joelalejandro
enhancements to state types, simplified signature
c2c3935
@joelalejandro
added Web3Provider mock
e4a4da8
@joelalejandro
moved Ethereum import inside action
a6d08df
@joelalejandro
updated StoreAction signature
0f42d29
@joelalejandro
implemented Wallet store tests
89d7c2a
@joelalejandro
Merge branch 'spersico/wallet-ui-testing' of github.com:counterfactua…
a002400 
…l/monorepo into spersico/wallet-ui-testing
@joelalejandro
moved util function to ethereum mock class
f990cdb
@joelalejandro
moved callAction to reusable util
566bcd2
@spersico spersico added DO NOT MERGE 📦 Wallet UI code related to packages/wallet-ui labels Jul 13, 2019
@spersico spersico requested a review from joelalejandro July 13, 2019 01:05
joelalejandro and others added 16 commits July 15, 2019 14:01
@joelalejandro
reorganized scaffolding under /src/store
110ae94
@spersico
initial accountDeposit integration tests
1cead40
@joelalejandro
first tests passing with mocked API!
a8ca7ed
@spersico
exclude from the coverage calc some trivial files
f93591e
@spersico
Merge branches 'spersico/wallet-ui-testing' and 'spersico/wallet-ui-t…
3359787 
…esting' of https://github.com/counterfactual/monorepo into spersico/wallet-ui-testing
@joelalejandro
added tests for loginUser()
9112f81
@joelalejandro
finished testing the User store module
a22f4e8
@joelalejandro
added unit tests for CF utils
3359479
@joelalejandro
finished testing all store modules
3900b73
@spersico
add mock wallet store module
7ee201e
@spersico
add integration test account deposit
2c1dee1
@spersico
small account deposit refactor
c73e125
@spersico
add initial integration testint for channels
59f25ed
@spersico
add unit testing for ChannelNode
48f5e1e
@spersico
remove log from previous commit
1d2c165
@spersico
add unit testing for widgetErrorMessage
b3ec696
@joelalejandro joelalejandro marked this pull request as ready for review July 17, 2019 14:31
@joelalejandro joelalejandro requested a review from snario as a code owner July 17, 2019 14:31
@joelalejandro joelalejandro added this to the 👽 Grunty milestone Jul 17, 2019
@joelalejandro joelalejandro merged commit 4c511ca into master Jul 17, 2019
@joelalejandro joelalejandro deleted the spersico/wallet-ui-testing branch July 17, 2019 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joelalejandro joelalejandro joelalejandro approved these changes

@snario snario Awaiting requested review from snario snario is a code owner

@ebryn ebryn Awaiting requested review from ebryn

@Alonski Alonski Awaiting requested review from Alonski

@briarsweetbriar briarsweetbriar Awaiting requested review from briarsweetbriar

Assignees

@joelalejandro joelalejandro

@spersico spersico

Labels
🐢 Testing 📦 Wallet UI code related to packages/wallet-ui
Projects
None yet
Milestone
👽 Grunty
Development

Successfully merging this pull request may close these issues.
2 participants
@spersico @joelalejandro