Skip to content
This repository was archived by the owner on Dec 13, 2019. It is now read-only.

[wallet-ui] Improve validity checks for FormInput #1954

Open
joelalejandro opened this issue Jul 22, 2019 · 0 comments
Open

[wallet-ui] Improve validity checks for FormInput #1954

joelalejandro opened this issue Jul 22, 2019 · 0 comments
Assignees
@spersico
Labels
🧬 Code Quality 📦 Wallet UI code related to packages/wallet-ui
Milestone
👽 Grunty

Comments

@joelalejandro
Copy link
Contributor

We have a bunch of ifs to return the proper error message according to each HTML5 validity state. Since the validity hashmap is non-enumerable, we probably want to rebuild it with an object map of our own, hold the error messages there and do some pattern matching to avoid having a long if-chain there.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@spersico spersico

Labels
🧬 Code Quality 📦 Wallet UI code related to packages/wallet-ui
Projects
None yet
Milestone
👽 Grunty
Development

No branches or pull requests
2 participants
@joelalejandro @spersico