Skip to content

Conversation

RichardSmedley
Copy link
Contributor

No description provided.

Copy link
Collaborator

@osfameron osfameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - couple of minor comments inline, mainly checking that the .Net EA change is intentionally bundled.


Couchbase is a multipurpose NoSQL database for transactional, analytical, mobile, and AI applications.
Develop at the edge with offline-first Couchbase Lite, for transactional workloads with SDKs in eleven popular programming languages, for real-time analytics, and build agentic apps (currently in private preview).
Develop at the edge with offline-first Couchbase Lite, for transactional workloads with SDKs in a dozen popular programming languages, for real-time analytics, and build agentic apps (currently in private preview).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"12" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads better, as a dozen is a hardwired concept for most peoples.

However, I'm aware that there are counter-arguments. 🤷

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way, you have to write "dozen" as "12" according to https://docs.couchbase.com/styleguide/numbers.html so it's moot :D

set $current_version_sdk_ruby_api '3.7.0';
set $current_version_sdk_scala_api '3.9.1';
set $current_version_analytics_dotnet_api '1.0.0';
set $current_version_analytics_dotnet_api '1.0.1';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

driveby .Net EA change, assume intended?

location ^~ /sdk-api/couchbase-scala-client/ { rewrite ^/sdk-api/(couchbase-scala-client)/(.*)$ /sdk-api/$1-$current_version_sdk_scala_api/$2 last; }
# Analytics SDKs
location ^~ /sdk-api/couchbase-analytics-dotnet-client/ { rewrite ^/sdk-api/(couchbase-analytics-dotnet-client)/(.*)$ /sdk-api/$1-$current_version_analytics_dotnet_api/$2 last; }
location ^~ /sdk-api/analytics-dotnet-client/ { rewrite ^/sdk-api/(analytics-dotnet-client)/(.*)$ /sdk-api/$1-$current_version_analytics_dotnet_api/$2 last; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, driveby .Net EA change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes,
.NET not following Java pattern on this occasion. :-/

such as connection management and robust error handling.
////

* xref:dotnet-analytics-sdk:hello-world:overview.adoc[.NET Analytics SDK Docs]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah,
while I was starting the Rust changes I noticed the missing entry on this page,
and thought I may as well also add in the 1.0.1 change
(1.0.0 has been removed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants