Skip to content

RSCBC-147: Fix various issues with running unit tests against a cluster_run-based cluster#323

Draft
Peter-Searby wants to merge 4 commits intomainfrom
RSCBC-147
Draft

RSCBC-147: Fix various issues with running unit tests against a cluster_run-based cluster#323
Peter-Searby wants to merge 4 commits intomainfrom
RSCBC-147

Conversation

@Peter-Searby
Copy link
Copy Markdown

This doesn't fix all of the issues faced when using cluster_run (some of which may or may not just be caused by flakiness in the tests), but does cover the following:

  • Some tests depend on a fixed mgmt port, which can't be met by a cluster_run. To fix this http bootstrapping support is added, so that a http:// connection string can be used to make the tests compatible with a cluster_run instance
  • Any tests depending on fixed ports for other services are switched to using ns_server's /_p/<service>/ proxy API, so that the mgmt port can be used for all such requests (note, this is not needed for any tests depending on any auto-discovery of ports)
  • The get_terse_cluster_config function was incorrectly using a streaming API, causing it to hang when used for bootstrapping, this has been switched to the correct API

@Peter-Searby Peter-Searby force-pushed the RSCBC-147 branch 2 times, most recently from 2d09eaf to 612ec3b Compare September 4, 2025 10:37
@Peter-Searby Peter-Searby force-pushed the RSCBC-147 branch 2 times, most recently from 9afdb85 to 6ca92c0 Compare September 4, 2025 11:22
Fix test_json_block_read in tests/http.rs to use the http port, not
just assume 8091.
The streaming API is being used in a non-streaming context, so it just
hangs.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Peter-Searby Peter-Searby marked this pull request as draft January 9, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants