Handle filler value for DateCode #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 87.30% 87.30%
=======================================
Files 7 7
Lines 819 819
=======================================
Hits 715 715
Misses 104 104 ☔ View full report in Codecov by Sentry. |
It appears that some EMU-2 devices will fill the date code with '\xff' characters in some scenarios. We've already seen some fields use 0xff to represent a sort of 'filler' value where there is no date to give. This scenario is a little bit different because the raw representation is 0xff where before we were seeing 0xff written out in ASCII characters, but given that the number of characters still matches documentation's expected value I think we can draw the same conclusion here. There are a few components to this change: 1. Switch from plain ASCII to codepage 1252 extended ASCII. This is actually called out in the RAVEn protocol documentation. 2. Set the _stash attribute earlier in the connection_made method to limit the fallout of any problems feeding the XML root tag to the parser. 3. Specifically handle an all-0xFF date code as 'None'.
cottsay
force-pushed
the
cottsay/date-code-filler
branch
from
32cea09 to
d37ea33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that some EMU-2 devices will fill the date code with '\xff' characters in some scenarios. We've already seen some fields use 0xff to represent a sort of 'filler' value where there is no date to give. This scenario is a little bit different because the raw representation is 0xff where before we were seeing 0xff written out in ASCII characters, but given that the number of characters still matches documentation's expected value I think we can draw the same conclusion here.
There are a few components to this change: