feat(snap): support typed uint crypto - #130
Merged
Merged
Conversation
vladi-coti
changed the title
gmesika-coti
requested changes
Jun 29, 2026
| return decodeUint(new Uint8Array([...ciphertext, ...r])).toString(); | ||
| }; | ||
|
|
||
| const encryptUint256Value = ( |
Member
There was a problem hiding this comment.
dont you think that this code should have being in the coti-sdk-typescript?
Member
Author
There was a problem hiding this comment.
sure, do you want me to create a PR for it in the sdk then change this PR?
| * Normalizes a JSON-RPC-safe confidential uint payload into the bigint shapes expected by | ||
| * SDK decrypt helpers. Exported so the parser can be tested without the Snap sandbox. | ||
| */ | ||
| export const normalizeCtPayload = ( |
Member
There was a problem hiding this comment.
dont you think that this code should have being in the coti-sdk-typescript?
…ayloads - Added a new RPC method 'decrypt-balance' to handle decryption of balance payloads. - Introduced utility functions for normalizing 64-bit and 256-bit balance formats. - Enhanced error handling for malformed balance entries and invalid variants. - Updated tests to cover new functionality and ensure robustness of the decryption process.
Route typed uint64/uint256 encryption and ctUint64/ctUint256 decryption through the existing RPCs so the AES key stays in Snap state. Remove the temporary decrypt-balance RPC.
gmesika-coti
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.