feature/comet v1 upgrade #8437
Draft
feature/comet v1 upgrade #8437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit does not port the ./e2e module, since it depends on interchaintest, which in turns depends on the ibc-go root module. this commit includes a port of the root module, which can then be imported by the upgraded interchaintest.
this commit updates the interchaintest dependency to a temporary commit of the fcecin/interchaintest fork which contains fixes for comet v1. this is a WIP as e2e tests are failing
faddat
requested review from
AdityaSripal,
gjermundgaraba,
srdtrk and
DeshErBojhaa
as code owners
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8437 +/- ##
==========================================
- Coverage 61.62% 1.18% -60.45%
==========================================
Files 299 14 -285
Lines 21462 1949 -19513
==========================================
- Hits 13227 23 -13204
+ Misses 7643 1925 -5718
+ Partials 592 1 -591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
the tests run for me locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.