-
Notifications
You must be signed in to change notification settings - Fork 694
fix: replace deprecated codec.ProtoMarshaler interface with proto.Message #8366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…age in UnmarshalMsgResponses
…in UnmarshalMsgResponses
Sorry for the long wait here! Could you please also add a changelog entry for this under Otherwise, I think this looks good and useful 🙏 Thank you! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8366 +/- ##
=======================================
Coverage 61.62% 61.62%
=======================================
Files 299 299
Lines 21462 21462
=======================================
Hits 13227 13227
Misses 7643 7643
Partials 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sorry for late answear, i've added changelog, thanks for review |
Co-authored-by: Tamjid Ahmed <[email protected]>
@DeshErBojhaa Yes, sorry |
Description
testing/utils.go
, replaced the parameter type in theUnmarshalMsgResponses
function fromcodec.ProtoMarshaler
toproto.Message
and added the necessary importe2e/testsuite/codec.go
, also replaced the parameter type in the identically named functionReplacing the deprecated interface helps avoid potential issues in the future when
codec.ProtoMarshaler
might be completely removed from the codebase. Using the recommendedproto.Message
interface aligns with SDK development best practices.The interface replacement maintains the same functionality as the implementation of the functions doesn't use any specific methods of the
codec.ProtoMarshaler
interface that aren't available inproto.Message
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.