Add field in callbacks data for custom calldata #8353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8353 +/- ##
==========================================
+ Coverage 61.62% 61.68% +0.05%
==========================================
Files 299 299
Lines 21462 21494 +32
==========================================
+ Hits 13227 13259 +32
Misses 7643 7643
Partials 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdityaSripal
requested review from
gjermundgaraba,
srdtrk and
DeshErBojhaa
as code owners
|
|
||
| calldata, err := hex.DecodeString(calldataStr) | ||
| if err != nil { | ||
| return nil |
There was a problem hiding this comment.
Are we sure this should not return an error?
…into aditya/cb-custom-calldata
|
Introduced tighter validation of callback data in memo. Though adding errors in all the helper functions is a bit ugly. Let me know if you would prefer panics. I'm finishing up testing this when I am back |
|
Sounds good. Errors seems fine, easier to test 🤷 |
| @@ -228,6 +228,55 @@ func (s *CallbacksTypesTestSuite) TestGetCallbackData() { | |||
| true, | |||
| nil, | |||
| }, | |||
| { | |||
| "success: source callback with calldata", | |||
There was a problem hiding this comment.
Note: we allow calldata on either side in ibc-go. EVM contract keeper will enforce calldata only set for dest calldata
…into aditya/cb-custom-calldata
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.