feat: added ics27-2 gmp application #8352
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
keep it up... |
| Status: channeltypesv2.PacketStatus_Failure, | ||
| } | ||
| } | ||
| if payload.Version != types.Version { |
There was a problem hiding this comment.
Should this check exist in SendPacket
|
|
||
| // getOrCreateICS27Account retrieves an existing ICS27 account or creates a new one if it doesn't exist. | ||
| func (k Keeper) getOrCreateICS27Account(ctx context.Context, accountID *types.AccountIdentifier) (*types.ICS27Account, error) { | ||
| existingIcs27Account, err := k.Accounts.Get(ctx, collections.Join3(accountID.ClientId, accountID.Sender, accountID.Salt)) |
There was a problem hiding this comment.
Why do you have this additional storage out of state?
There was a problem hiding this comment.
Seems redundant with accountKeeper
|
|
||
| // CacheContext returns a new context with the multi-store branched into a cached storage object | ||
| // writeCache is called only if all msgs succeed, performing state transitions atomically | ||
| cacheCtx, writeCache := ctx.CacheContext() |
There was a problem hiding this comment.
No gas limit, should this be in the tx passed into the payload?
| } | ||
|
|
||
| // CosmosTx contains a list of sdk.Msg's. It should be used when sending transactions to an SDK host chain. | ||
| message CosmosTx { |
There was a problem hiding this comment.
Should this use the standardized message cosmos uses?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.